From owner-cvs-src@FreeBSD.ORG Mon Jan 30 17:26:54 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA90E16A420; Mon, 30 Jan 2006 17:26:54 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9CC4B43D49; Mon, 30 Jan 2006 17:26:52 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id k0UHOwQ1017753; Mon, 30 Jan 2006 10:24:59 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 30 Jan 2006 10:24:58 -0700 (MST) Message-Id: <20060130.102458.41650754.imp@bsdimp.com> To: peterjeremy@optushome.com.au From: Warner Losh In-Reply-To: <20060129000818.GF2341@turion.vk2pj.dyndns.org> References: <20060128223343.GE2341@turion.vk2pj.dyndns.org> <20060128225700.GA88332@freebie.xs4all.nl> <20060129000818.GF2341@turion.vk2pj.dyndns.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 30 Jan 2006 10:24:59 -0700 (MST) Cc: rodrigc@freebsd.org, wb@freebie.xs4all.nl, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sbin/mount Makefile extern.h mount_ufs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2006 17:26:55 -0000 From: Peter Jeremy Subject: Re: cvs commit: src/sbin/mount Makefile extern.h mount_ufs.c Date: Sun, 29 Jan 2006 11:08:18 +1100 > On Sat, 2006-Jan-28 23:57:00 +0100, Wilko Bulte wrote: > >On Sun, Jan 29, 2006 at 09:33:43AM +1100, Peter Jeremy wrote.. > >> On Fri, 2006-Jan-27 21:57:25 -0800, David O'Brien wrote: > >> >On Wed, Dec 07, 2005 at 06:40:17PM -0800, David O'Brien wrote: > >> >> On Wed, Nov 23, 2005 at 11:22:56PM +0000, Craig Rodrigues wrote: > >> >> > rodrigc 2005-11-23 23:22:56 UTC > >> >> > > >> >> > FreeBSD src repository > >> >> > > >> >> > Modified files: > >> >> > sbin/mount Makefile extern.h > >> >> > Removed files: > >> >> > sbin/mount mount_ufs.c > >> >> > Log: > >> >> > Remove UFS-specific parts from mount(8). > >> >> > For mounting UFS, all mount options are passed directly to nmount(), > >> >> > without any UFS-specific logic. > >> >> > >> >> Where do we stand on making 'mount /' from single user work again? > >> > > >> >Can you give us an update on where you stand on making 'mount /' work > >> >again from single user? We've been suffering from this for 2 months now. > >> > >> "mount -r" also no longer works if the FS is marked "rw" in /etc/fstab. > >> Instead you have to use "mount -o norw". How about having "ro" imply > >> "norw" and vice versa. > > > >Blurk.. norw == ro and noro == rw? What is wrong with just sticking with > >plain and simple rw and ro ? > > ro and rw still exist but, based on my reading of the code, the options > you enter are appended to the options in fstab so that if you say > "mount -r" (or "mount -o ro"), nmount(2) is passed "rw,ro" and the "rw" > over-rides the "ro". "norw" makes mount(8) strip the "rw" and then > nmount(2) defaults to ro. > > I think mount(8) needs to grow some special-casing so that it knows that > "ro" and "rw" are complementary. Agreed. mount -ur / and mount -uw / need to work no matter what is in /etc/fstab. They are heavily used in many scripts, for example, in embedded and semi-embedded products. Warner