From owner-cvs-src@FreeBSD.ORG Mon Oct 3 22:16:12 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B2E916A41F; Mon, 3 Oct 2005 22:16:12 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE8B843D46; Mon, 3 Oct 2005 22:16:11 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [70.30.70.180]) by elvis.mu.org (Postfix) with ESMTP id BB13E1A3C2D; Mon, 3 Oct 2005 15:16:11 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 111BA51424; Mon, 3 Oct 2005 18:16:09 -0400 (EDT) Date: Mon, 3 Oct 2005 18:16:08 -0400 From: Kris Kennaway To: Don Lewis Message-ID: <20051003221608.GA98675@xor.obsecurity.org> References: <200510032157.j93LvhM7022905@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: <200510032157.j93LvhM7022905@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2005 22:16:12 -0000 --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 03, 2005 at 09:57:43PM +0000, Don Lewis wrote: > truckman 2005-10-03 21:57:43 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/ufs/ffs ffs_alloc.c=20 > Log: > Initialize the inode i_flag field in ffs_valloc() to clean up any > stale flag bits left over from before the inode was recycled. > =20 > Without this change, a leftover IN_SPACECOUNTED flag could prevent > softdep_freefile() and softdep_releasefile() from incrementing > fs_pendinginodes. Because handle_workitem_freefile() unconditionally > decrements fs_pendinginodes, a negative value could be reported at > file system unmount time with a message like: > unmount pending error: blocks 0 files -3 > The pending block count in fs_pendingblocks could also be negative > for similar reasons. These errors can cause the data returned by > statfs() to be slightly incorrect. Some other cleanup code in > softdep_releasefile() could also be incorrectly bypassed. > =20 > MFC after: 3 days Yeah! This also affects 5.x, by the way. Kris --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDQa2oWry0BWjoQKURAgM2AKDqbqNvzq68EkMZEmSvn5bcS6RSAQCggLl/ kkzX6Ow3+9yL8H1wgMS84Rk= =6lw+ -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--