From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 21 09:10:03 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6835216A419 for ; Mon, 21 Jan 2008 09:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4C71213C4EC for ; Mon, 21 Jan 2008 09:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0L9A3vJ038468 for ; Mon, 21 Jan 2008 09:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0L9A3gs038467; Mon, 21 Jan 2008 09:10:03 GMT (envelope-from gnats) Date: Mon, 21 Jan 2008 09:10:03 GMT Message-Id: <200801210910.m0L9A3gs038467@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Dan Lukes Cc: Subject: Re: ports/119844: security/nmap 4.53 has been released (we missed 4.21,4.22,4.23,4.50,4.51,4.52 already) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2008 09:10:03 -0000 The following reply was made to PR ports/119844; it has been noted by GNATS. From: Dan Lukes To: Daniel Roethlisberger Cc: bug-followup@FreeBSD.org Subject: Re: ports/119844: security/nmap 4.53 has been released (we missed 4.21,4.22,4.23,4.50,4.51,4.52 already) Date: Mon, 21 Jan 2008 10:03:14 +0100 Daniel Roethlisberger napsal/wrote, On 01/21/08 07:50: > Please do NOT commit this PR. See ports/119673 with my maintainer > update to 4.52 I searched the databaze for such PR but I miss them. I wasted a few hours of my time and a lot of yours time also. Sorry. > If you think your patch handles anything I missed in ports/119673, please drop me an email. It's not easy to say as I worked with 4.53 and your patches are related to 4.52. In 4.53 the nmap will use internal lua despite of your configuration requesting linking against external library. At the first, there is a typo in configure script that prevent the external LUA to be tried at all. At the second, when corrected, there are another bug that cause the test will fail (#if BYTE_ORDER but #include with BYTE_ORDER not included). At the third, even the external LUA successfully detected, the build fail at the linking phase as LUA require libm to be linked but no -lm present. There may be no such bugs in 4.52 or your miss the internal lua is used despite of your configuration. I would like to suggest you another change - you modified the pkg-plist statically. It mean you must reevaluate the list every update. See post-install section in my Makefile - the list of installed script is generated dynamically according actual list in particular version - the same way as own nmap installation script did it. It's your decision, of course, but dynamic generation may save your time and avoid bugs in packing list durign future updates. You miss the installation of zenmap.1 MAN page (if present within 4.52). > there have been no stable releases between 4.20 and > 4.52, so we missed not a single one. Using nmap for professional work > on a regular basis, reliability is more important to me than bleeding > edge new features I'm not interested in new features (even the zenmap didn't interest me). But too ancient os-fingerprint database and MAC OUI database prevent professional use of nmap against current computers. Dan