Date: Wed, 16 Nov 2011 10:07:14 -0800 From: Xin LI <delphij@delphij.net> To: Robert Millan <rmh@freebsd.org> Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>, freebsd-current@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers Message-ID: <4EC3FBD2.4070009@delphij.net> In-Reply-To: <CAOfDtXPX1Rv9T7%2B1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com> References: <CAOfDtXPX1Rv9T7%2B1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 11/16/11 09:27, Robert Millan wrote: > Hi! > > Out of the kernel headers that are installed in /usr/include/ > hierracy, there are some which include support multiple operating > systems (usually FreeBSD and other *BSD flavours). > > This patch adds support to detect GNU/kFreeBSD as well. In all > cases, we match the same declarations as FreeBSD does (which is to > be expected in kernel headers, since both systems share the same > kernel). > > Does it look fine? Just my $0.02 -- I think we should probably do it in a more centralized place -- otherwise in case someone imported some new code, they have to do the same defined(__FreeBSD__) || defined(__FreeBSD_kernel__)? Cheers, - -- Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iQEcBAEBCAAGBQJOw/vSAAoJEATO+BI/yjfBozIIAMuqmkNkDkWG4Kra/mQ5HQXZ Oe/bndGzfUl9H6epFZWc+eeT2zxnlvVUGwVf5si3THU23dZkmynbPj1NnY+oDewt TwB5nbG0tcClMMesK8L9lJB5AxKHsRtILK8l8xMzsJEj6fRjb8+yrjj8LLK7zUNk gTQA/sOVR2a4ZARkUlvbgNsE/BBx7NijxFS3uMA91AgsXAniBp4ND6dDwAudQIpW MqLH4DxJX/6EC2E9ibM5IBB8wguaUWF52oHLGnRAs2JkXzNS/qj6aSepjivSIUzh gtKKteCpRNexnWq+2pym9OE6tmxW8uoPNUuBxZqOP+laabcn392silZrE0yElh8= =XHtJ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EC3FBD2.4070009>