From owner-freebsd-arch@freebsd.org Thu Jun 30 21:08:31 2016 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2858CB88BF6 for ; Thu, 30 Jun 2016 21:08:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0E18820E2 for ; Thu, 30 Jun 2016 21:08:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0D5FCB88BF4; Thu, 30 Jun 2016 21:08:31 +0000 (UTC) Delivered-To: arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D0FDB88BF3 for ; Thu, 30 Jun 2016 21:08:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id F08DB20E1; Thu, 30 Jun 2016 21:08:30 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id AD3DB1FFE; Thu, 30 Jun 2016 21:08:30 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 55B7F1CE0A; Thu, 30 Jun 2016 21:08:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id eXlTad5Fhbj7; Thu, 30 Jun 2016 21:08:27 +0000 (UTC) Subject: Re: Build work 11.0 plans status update DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 9972B1CE03 To: "Simon J. Gerraty" References: <201605270001.u4R01mKT087678@repo.freebsd.org> <20160527182543.GB4025@FreeBSD.org> <0d639d52-3ed4-a86d-3d45-b93c02939ce7@FreeBSD.org> <99714.1467316694@kaos.jnpr.net> Cc: arch@freebsd.org From: Bryan Drewery Organization: FreeBSD Message-ID: <84851e7b-60b9-b3dc-7410-45dc2b3ba1c1@FreeBSD.org> Date: Thu, 30 Jun 2016 14:08:27 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <99714.1467316694@kaos.jnpr.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 21:08:31 -0000 On 6/30/16 12:58 PM, Simon J. Gerraty wrote: > Bryan Drewery wrote: >> 3. Default AUTO_OBJ in subdirs. This one is kind of tricky and need= s >> some more thought. Non-root especially may be problematic since >> it will try to write to /usr/obj by default. I likely will hold >> off on this and not propose it for 11.0. >=20 > Surely this can be made dependent on writability of OBJROOT (/usr/obj/)= ? >=20 Maybe. I'd rather not introduce something like this since it is invoked from sys.mk. I really hate adding more executions. To bad there is no make writable() function... CAN_WRITE!=3D test -w ${MAKEOBJDIR} && echo 1 || echo 0 # The above test is not really enough either since we want to test every component of the directory which is what mkdir -p is already doing in auto.obj.mk... .if ${CAN_WRITE} =3D=3D 1 __DEFAULT_YES_OPTIONS+=3D AUTO_OBJ .endif .include .if ${MK_AUTO_OBJ} =3D=3D "yes" .include .endif What seems more efficient to me is to default AUTO_OBJ to on and then have auto.obj.mk consider an EPERM to just disable the feature for some cases. The 'for some cases' is where it becomes murky since we want to force auto obj on for things like buildworld/DIRDEPS regardless of writability as those should error and stop. Building a user or in a subdir (not DIRDEPS) may be fine to ignore the EPERM and build in source tree since that's a historical behavior. --=20 Regards, Bryan Drewery