From owner-cvs-src@FreeBSD.ORG  Tue Aug  5 05:28:22 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9F49937B401; Tue,  5 Aug 2003 05:28:22 -0700 (PDT)
Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2653643F75; Tue,  5 Aug 2003 05:28:21 -0700 (PDT)
	(envelope-from k@numeri.campus.luth.se)
Received: from numeri.campus.luth.se (localhost [127.0.0.1])
	by numeri.campus.luth.se (8.12.9/8.12.9) with ESMTP id h75CSHbp056804;
	Tue, 5 Aug 2003 14:28:17 +0200 (CEST)
	(envelope-from k@numeri.campus.luth.se)
Received: (from k@localhost)
	by numeri.campus.luth.se (8.12.9/8.12.9/Submit) id h75CSGDq056803;
	Tue, 5 Aug 2003 14:28:16 +0200 (CEST)
Date: Tue, 5 Aug 2003 14:28:15 +0200
From: Johan Karlsson <johan@FreeBSD.org>
To: Diomidis Spinellis <dds@FreeBSD.org>
Message-ID: <20030805122815.GA17099@numeri.campus.luth.se>
References: <200308050722.h757MCxl098780@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200308050722.h757MCxl098780@repoman.freebsd.org>
User-Agent: Mutt/1.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/sym sym_fw.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Aug 2003 12:28:23 -0000

On Tue, Aug 05, 2003 at 00:22 (-0700) +0000, Diomidis Spinellis wrote:
> dds         2003/08/05 00:22:12 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/sym          sym_fw.h 
>   Log:
>   Remove extraneous semicolons.  They are already provided by
>   the macro definition, and cause the generation of syntactically
>   incorrect code that gcc happens to accept.

This is backwards.

>From style(9):
						      Any final statement-ter-
     minating semicolon should be supplied by the macro invocation rather than
     the macro, to make parsing easier for pretty-printers and editors.

Please consider reverting this and change the macros in the file to not
supply the terminating semicolon.

/Johan K

>   
>   Reviewed by:    schweikh (mentor)
>   MFC after:      4 weeks
>   
>   Revision  Changes    Path
>   1.4       +4 -4      src/sys/dev/sym/sym_fw.h

-- 
Johan Karlsson		mailto:johan@FreeBSD.org