From owner-freebsd-stable@FreeBSD.ORG Thu Jul 4 17:25:37 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id AB9EED63; Thu, 4 Jul 2013 17:25:37 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 1E63C1295; Thu, 4 Jul 2013 17:25:36 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r64HPSXT097022; Thu, 4 Jul 2013 20:25:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r64HPSXT097022 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r64HPSlu096994; Thu, 4 Jul 2013 20:25:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 4 Jul 2013 20:25:28 +0300 From: Konstantin Belousov To: Andre Albsmeier Subject: Re: FreeBSD-9.1: machine reboots during snapshot creation, LORs found Message-ID: <20130704172528.GL91021@kib.kiev.ua> References: <20130531122611.GA6607@bali> <201305311051.03157.jhb@freebsd.org> <20130616063942.GA72803@bali> <201306171530.31208.jhb@freebsd.org> <20130704051409.GA22021@bali> <20130704052440.GG91021@kib.kiev.ua> <20130704052659.GA23398@bali> <20130704061550.GI91021@kib.kiev.ua> <20130704142919.GA1798@bali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+odIVbikbWChO5Pj" Content-Disposition: inline In-Reply-To: <20130704142919.GA1798@bali> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: "freebsd-stable@freebsd.org" , John Baldwin X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jul 2013 17:25:37 -0000 --+odIVbikbWChO5Pj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 04, 2013 at 04:29:19PM +0200, Andre Albsmeier wrote: > OK, patch is applied. I will reboot the machine later > and see what happens tomorrow in the morning. However, > it might take a few days since the last 2 weeks all was > fine. >=20 > BTW, should this patch be used in general or is it just > for debugging? My understanding is that it is something > which could stay in the code... Patch is to improve debugging. I probably commit it after the issue is closed. Arguments against the commit is that the change imposes small performance penalty due to save and restore of the %ebp (I doubt that this is measureable by any means). Also, arguably, such change should be done for all functions in support.s, but bcopy() is the hot spot. --+odIVbikbWChO5Pj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJR1bAHAAoJEJDCuSvBvK1BIGoQAIMnJE9nUDY0qixM7EHG/A8Q q+hiwDtOqUyBfEsmrC/+hQMGZJYmyTpI+pgsnI1VWwZgeUaqswv9a+h2qvHqTDCu 8IGJZRtDpTS+tGnDAAxxiEVJ+NGJ3gSDYx2qtSty7eQVQls7eB4q87FA6I+6cZex djinQtLJGo2oesUzojvrVdkFS8GgvO5wm4aveoWAXGCx1otPR+bswjLSBFpToDm4 KE5lFtRYVsBSggaw8TzDJrUIpDqhXYY3dObgAtpz0sCINwGaKvSGTIQxJFpN1cW+ JnMmzPF0SePm7IJd0jRzmkC2X/5aNaziw0P6cgWCnY5Qjs16jr3HRroU0tzJVM3L Vq3m84xrQCZlkhg2hsE5YMMuVv+mEeyL77ev69oFVuplIj/oifsQvv6wXkaVKc06 3Wte4XcR1w3l9qRgI2Nj5sp1KTX2dVJ0b+Cw914HygeQlZ5eAiU/XucVmPe6pnCq ReLUyFJVjVFjbG4x2PhHGNGdJ17hVsfLumREanaZUxhUDQ+KQ1BPeU7OKtBcezlS Nm2gNtaHBCSY0yQgAjbbd33j5WhEYeqAFM28Vzz/DCj09pWM9RisNpzfsFabjW0v OnBpKyAzmPyo2SL8Y9X32B34p42GNXy4/UVQq9JziiyNIvReza+EtnXDSjOnWEtk Eka18BFj4vrFmd75N9Uf =2GFI -----END PGP SIGNATURE----- --+odIVbikbWChO5Pj--