From owner-freebsd-hackers@FreeBSD.ORG Tue Dec 7 17:58:46 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB815106564A for ; Tue, 7 Dec 2010 17:58:46 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 1FC348FC0A for ; Tue, 7 Dec 2010 17:58:45 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA06391 for ; Tue, 07 Dec 2010 19:58:44 +0200 (EET) (envelope-from avg@freebsd.org) Message-ID: <4CFE75D3.4050009@freebsd.org> Date: Tue, 07 Dec 2010 19:58:43 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101029 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: atomic_set_xxx(&x, 0) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2010 17:58:46 -0000 $ glimpse atomic_set_ | fgrep -w 0 /usr/src/sys/dev/arcmsr/arcmsr.c: atomic_set_int(&acb->srboutstandingcount, 0); /usr/src/sys/dev/arcmsr/arcmsr.c: atomic_set_int(&acb->srboutstandingcount, 0); /usr/src/sys/dev/jme/if_jme.c: atomic_set_int(&sc->jme_morework, 0); /usr/src/sys/dev/jme/if_jme.c: atomic_set_int(&sc->jme_morework, 0); /usr/src/sys/dev/ale/if_ale.c: atomic_set_int(&sc->ale_morework, 0); /usr/src/sys/mips/rmi/dev/xlr/rge.c: atomic_set_int(&(priv->frin_to_be_sent[i]), 0); /usr/src/sys/dev/drm/drm_irq.c: atomic_set_rel_32(&dev->vblank[i].count, 0); /usr/src/sys/dev/cxgb/ulp/tom/cxgb_tom.c: atomic_set_int(&t->tids_in_use, 0); I wonder if these are all bugs and atomic_store_xxx() was actually intended? -- Andriy Gapon