From owner-freebsd-bugs  Wed Nov 17 12:50: 5 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id AD01614C8D
	for <freebsd-bugs@FreeBSD.org>; Wed, 17 Nov 1999 12:50:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id MAA24467;
	Wed, 17 Nov 1999 12:50:00 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from sec.gta.com (fishsmell.gta.com [199.120.225.69])
	by hub.freebsd.org (Postfix) with ESMTP id 50CCB14BF4
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 17 Nov 1999 12:44:39 -0800 (PST)
	(envelope-from lab@sec.gta.com)
Received: (from lab@localhost)
	by sec.gta.com (8.9.3/8.9.3) id PAA06285;
	Wed, 17 Nov 1999 15:52:44 -0500 (EST)
	(envelope-from lab)
Message-Id: <199911172052.PAA06285@sec.gta.com>
Date: Wed, 17 Nov 1999 15:52:44 -0500 (EST)
From: lab@gta.com
Reply-To: lab@gta.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/14958: memory leak in UDP blackhole processing in udp_usrreq.c for current
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         14958
>Category:       kern
>Synopsis:       memory leak in UDP blackhole processing in udp_usrreq.c
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 17 12:50:00 PST 1999
>Closed-Date:
>Last-Modified:
>Originator:     Larry Baird
>Release:        FreeBSD 4.0
>Organization:
Global Technology Associates
>Environment:

	FreeBSD 4.0 source code for udp_usreq.c

>Description:

	The logic for blackhole processing does not free mbufs if the
	blackhole flag is set.

>How-To-Repeat:

	Send some UDP packets to unopened ports on a FreeBSD 4.0 box with
	UDP blackhole turned on.

>Fix:
*** udp_usrreq.c        Wed Nov 10 11:58:47 1999
--- /tmp/udp_usrreq.c   Wed Nov 17 15:50:58 1999
***************
*** 307,312 ****
--- 307,314 ----
  #endif
                if (!blackhole)
                        icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_PORT, 0, 0);
+               else
+                       goto bad;
                return;
        }

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message