From owner-freebsd-usb@FreeBSD.ORG  Fri Mar 13 14:37:55 2009
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 45DCE10656C7;
	Fri, 13 Mar 2009 14:37:55 +0000 (UTC)
	(envelope-from hselasky@freebsd.org)
Received: from swip.net (mailfe11.swip.net [212.247.155.65])
	by mx1.freebsd.org (Postfix) with ESMTP id 9C4A08FC21;
	Fri, 13 Mar 2009 14:37:54 +0000 (UTC)
	(envelope-from hselasky@freebsd.org)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=bl9BoFr_XwQA:10 a=lzAowTwBfswA:10
	a=F9Ddb8ZnJZvc46m2WQEPHQ==:17 a=Coy6ztYMltRxVyoarD4A:9
	a=HVntGogZZX_FnQwE5YYA:7 a=UDRPgHvC5ShGbnGHO3Oy73jfsuEA:4
	a=LY0hPdMaydYA:10 a=_eTgx-yqqz6oJIgc:21 a=NCPyVS8tovhdUxJP:21
Received: from [85.19.79.136] (account mc467741@c2i.net HELO
	laptop.bitfrost.local)
	by mailfe11.swip.net (CommuniGate Pro SMTP 5.2.6)
	with ESMTPA id 1037083763; Fri, 13 Mar 2009 14:37:51 +0100
From: Hans Petter Selasky <hselasky@freebsd.org>
To: freebsd-usb@freebsd.org
Date: Fri, 13 Mar 2009 14:40:20 +0100
User-Agent: KMail/1.9.7
References: <alpine.BSF.2.00.0902161129060.5806@fledge.watson.org>
	<20090217052121.GB86244@weongyo.cdnetworks.kr>
	<alpine.BSF.2.00.0903131136500.61873@fledge.watson.org>
In-Reply-To: <alpine.BSF.2.00.0903131136500.61873@fledge.watson.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200903131440.22224.hselasky@freebsd.org>
Cc: usb@freebsd.org, Weongyo Jeong <weongyo@freebsd.org>,
	Robert Watson <rwatson@freebsd.org>, thompsa@freebsd.org
Subject: Re: USB support in NDIS -- IFF_NEEDSGIANT?
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Mar 2009 14:37:56 -0000

On Friday 13 March 2009, Robert Watson wrote:
> On Tue, 17 Feb 2009, Weongyo Jeong wrote:
> >> As you know, I've been gradually working to eliminate all non-MPSAFE
> >> network device driver infrastructure for 8.0, having removed non-MPSAFE
> >> network protocol infrastructure in 7.0.  In reviewing remaining drivers
> >> using IFF_NEEDSGIANT, I spotted this in the NDIS code:
>
> ...
>
> >> Having taken a glance, it looks like this was added specifically to
> >> support USB devices attached via NDIS.
> >
> > AFAIK all of usb wireless drivers had it so I couldn't avoid it when I
> > had implemented.
> >
> >> With the new USB code, are NDIS drivers still supported?
> >
> > I think that it would be supported at 8.0
> >
> >> And in the new world order, is this IFF_NEEDSGIANT still required?
> >
> > Probably we can remove the IFF_NEEDSGIANT flags at the new USB code.
> >
> >> Can I simply remove it once the old USB code is on the way out the door?
> >
> > IMHO yes I think.
>
> Dear all:
>
> A few weeks have passed, so I wanted to check in and see how this project
> was going -- are we at a point yet where removing IFF_NEEDSGIANT won't
> cause significant loss of functionality?

I think both NDIS USB and USB Ethernet/WLAN drivers have been made Giant-free.

--HPS