From owner-freebsd-ports@freebsd.org Mon Apr 17 16:13:52 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 171E0D428AB for ; Mon, 17 Apr 2017 16:13:52 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id EBEB8FF4 for ; Mon, 17 Apr 2017 16:13:51 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mailman.ysv.freebsd.org (Postfix) id EB4B4D428AA; Mon, 17 Apr 2017 16:13:51 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAF79D428A9 for ; Mon, 17 Apr 2017 16:13:51 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-oi0-x235.google.com (mail-oi0-x235.google.com [IPv6:2607:f8b0:4003:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B4941FF3 for ; Mon, 17 Apr 2017 16:13:51 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-oi0-x235.google.com with SMTP id r203so146780646oib.3 for ; Mon, 17 Apr 2017 09:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=KD4WTLwZCZw2nvNUxS0PmCn1XMWMCcpqdZsfNnkUK78=; b=pzS/+VdwFbWdXORuf8ptx+X/1FmeDfDTmc94EGXZcG8x1clzrAY7A5Am7HUMXJ5h4x aqQt1JPNGR4qbgcEJ8LFN26DRvs3Jyl0EWNxTLEDCTsgTXqoEs94iGXAiTkvvoZ17JCa WeWeZJMwO90snlf4iTwwEhJ6Y+cLJVF80Crd6ndqhMhg0adTlNv2AmmsJFq001MQvbc/ cKD5i6xslCnClVyWulgxqP78cfaymY4OShgdn7YgSVyKzopJqODO/4dUGCL7Bs8UpmAC ogH3y8GVRPFf3TW6bQLvEvwLO6eJJFNk1PWd6nlhsjJd30ec5Vc7UgOKTpp9+WEIqpTE /3Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=KD4WTLwZCZw2nvNUxS0PmCn1XMWMCcpqdZsfNnkUK78=; b=EYQluaYbMDeXyapZ34SeHH9Z6521dDnzbUCabTb6YnfVf9I2zMkfVru0oRj1NZq3bn Hejs6r5l0ulxCpwg9V7UuHtQn2cRmmieix3JY/k7i11MNaQ/VhLPQM+DMr5sOFTVfTs/ CaohRFOIoU3J0xohqb6lGyDw8ZA9hpeJm3Di9/+o1c+N2vxvW+465oAjbL7PYwpqCxAy pt6vHtnQGpVwSFIkwS0mvmdGGdZh6OJJ07lQfft2Wv+l8MOXhtehqip5WXRjGbOi05Lf Jqt/NBnll6nRAzYfFX2KSgyVF7wIV+xj2KnO1XF3BXlYKBnHyirhGrzTu4Crw8FLO067 +Z1g== X-Gm-Message-State: AN3rC/6tNOZ2FhOeN8lf0/17rgThEhKeeFWnrDLCEdmhQCGy6Ibtfz2F D9Ue5z/GczQaOu/i8BfHs7bXriFgBxeMUhQ= X-Received: by 10.157.62.76 with SMTP id h12mr5134347otg.95.1492445630964; Mon, 17 Apr 2017 09:13:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Steven Hartland Date: Mon, 17 Apr 2017 16:13:40 +0000 Message-ID: Subject: Re: Packaging Go Libs To: Steve Wills , ports@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Apr 2017 16:13:52 -0000 Agreed we shouldn't vendor go libraries On Mon, 17 Apr 2017 at 15:20, Steve Wills wrote: > Hi, > > I'd like to propose eliminating packaging of Go libs. > > Almost every Go app is developed with a different version of any given > lib than what another Go app might use. Forcing a Go app to use a > different version than what upstream might have chosen is error prone at > best and likely to produce a build that's unsupported upstream. So for > the packaged libs to even be useful, we would have to have as many > versions of each lib as there are consumers, or nearly as many. > > Further, best practice in the Go community is for Go apps to vendor all > their dependencies and almost all apps do that. This is the reason most > Go apps use different versions of it's libs. > > So to me, packaging Go libs doesn't make sense and I think we should > remove the Go libs from ports. > > Existing ports which use the Go libs should be updated to not use the Go > lib ports by doing one of these, in priority order: > > * Converted to using vendored deps included with the package source if > possible (preferred) > * Fetching the versions of deps specified by upstream (in the case of > vendor.json) > * As a last resort (deps are not included nor versions specified > exactly) fetching versions of deps available at the time of upstream > development > > Further, documentation should be added to the Porters Handbook saying > that we don't package Go libs and portlint should be updated to check > for installing files in GO_SRCDIR and GO_LIBDIR (exceot lang/go*). > > For reference, here's the list of Go lib ports that I found at the moment: > > archivers/go-compress > databases/gomdb > databases/gosqlite3 > databases/levigo > databases/radix.v2 > databases/redigo > devel/go-bayesian > devel/go-cobra > devel/go-codec > devel/go-cpuid > devel/go-crc32 > devel/go-faker > devel/go-form > devel/go-go.uuid > devel/go-goregen > devel/go-hashicorp-logutils > devel/go-json-rest > devel/go-logrus > devel/go-metrics > devel/go-nuid > devel/go-pflag > devel/go-protobuf > devel/go-raw > devel/go-runewidth > devel/go-slices > devel/go-sql-driver > devel/go-uuid > devel/go-yaml > devel/goprotobuf > net/go-amqp > net/go-geoip > net/go-httppath > net/go-httptreemux > net/go-nats > net/go.net > security/go.crypto > security/goptlib > textproc/go.text > www/go-fasthttp > www/webgo > > Does anyone have any objection or reasoning why this doesn't make sense? > > Thanks, > Steve > >