From nobody Fri Mar 11 20:21:04 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D6DA31A1F3FA for ; Fri, 11 Mar 2022 20:21:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KFcl44dCTz3LsT for ; Fri, 11 Mar 2022 20:21:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7FE621F551 for ; Fri, 11 Mar 2022 20:21:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22BKL4jL081515 for ; Fri, 11 Mar 2022 20:21:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22BKL4SI081514 for ports-bugs@FreeBSD.org; Fri, 11 Mar 2022 20:21:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 262489] security/duo: incorrect paths in man pages Date: Fri, 11 Mar 2022 20:21:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: andrew.daugherity@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: zi@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647030064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WQ72kFWTY/ItRA50DIW8fEqTAQBqAXFiNzwCq0ecI1M=; b=fSVkLWp26wsGYhzUKF4kTtfd7vGFx9vCABwBdVlZCOLc861L9m3pfJHV5aL6rJHaoZ+Qel 6FRte4YU4nwU5rFV2hOxHCYXd3fYOw0OKM8xpzc84dJZMUwpLdBChirj4BstgJnmJKcryy 64GDid7pbg/Pxuok46URuwGuIyrbRIf8+ZImkh+/QUQ4Z4HEALUW2xH3UtG7ZPe1ykK9gX Zm+P9nh41uQaOWaHXk06sCWGxHWrIelRtbGAK6AKYje7kCgM2pI7Krhcerhnh9y0EWFKGZ k5kxNhcgDfREGPwVuDfjQ6DUfWzIoPo3mBtalbunuqtn/+Y/PnPhEUd962/XDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647030064; a=rsa-sha256; cv=none; b=UwMwYaVmpUJUBY+7Q7f5KxMABauhvIC96S/K0ZCGYanUhcEP/IT4pwIfMu165nwmSzuz/5 528yL9m/7A31XCn4wZCm3Sgnl8v55QgeGJ28nOtmjpKZdvl6dGquIW93ooy61mk0OcAiFY V1bQAwWlBMOqyCMVJ9UKQgr5Z7sgIIXhLrQEDIgLKaXCg6cpFilRYTug0MthmfPtQA2zmU 1izv9QEq0xT1RP5/A0NX7/ZG3KzEG1JOx8reBbkAjUeumkStBZXdvvf0RoRORxLAhBh9ib lXpEEPY4LBv/4u80WEIhFeRSBjVHRuytnv8xQF/77sghKxngrwkOjKvaEv7vEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262489 Bug ID: 262489 Summary: security/duo: incorrect paths in man pages Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: zi@FreeBSD.org Reporter: andrew.daugherity@gmail.com Flags: maintainer-feedback?(zi@FreeBSD.org) Assignee: zi@FreeBSD.org The man pages for login_duo(8) and pam_duo(8) state that the default config file path is /usr/local/etc/duo/{login,pam}_duo.conf but that is incorrect = -- the port configures it with '--sysconfdir=3D${PREFIX}/etc' aka /usr/local/e= tc.=20 (The upstream default sysconfdir [1] is /etc/duo, not /etc!) Sample config files are installed into /usr/local/etc and when properly configured, Duo does indeed work with files in this location. Additionally, login_duo(8) refers to /usr/local/etc/motd and pam_duo(8) ref= ers to /usr/local/etc/passwd, both of which are obviously incorrect. I believe these are both caused by the ${REINPLACE_CMD} -e 's| /etc| ${PREFIX}/etc|g' in the port Makefile. I think that changing this to 's|/etc/duo|${PREFIX}/etc|g' should fix both issues, namely: - stripping the duo subdir, i.e. /etc/duo =3D> /usr/local/etc - not matching top-level /etc files like motd and passwd [1] https://github.com/duosecurity/duo_unix/blob/5b1f55e06c1760f32c541c8d8ae56b= 78c2cbfa1d/configure.ac#L26 --=20 You are receiving this mail because: You are the assignee for the bug.=