Date: Thu, 21 Jan 2016 15:31:25 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Raphael Kubo da Costa <rakuco@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r406842 - head/Mk/Scripts Message-ID: <20160121153124.GA15322@FreeBSD.org> In-Reply-To: <201601211025.u0LAPufi069384@repo.freebsd.org> References: <201601211025.u0LAPufi069384@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 21, 2016 at 10:25:56AM +0000, Raphael Kubo da Costa wrote: > New Revision: 406842 > URL: https://svnweb.freebsd.org/changeset/ports/406842 > > Log: > smart_makepatch: Quote PATCH_WRKSRC when regenerating patches. > > [...] > @@ -184,9 +184,9 @@ regenerate_patches() { > local OUT > local ORIG > local new_list > - new_list=$(cd ${PATCH_WRKSRC} && \ > + new_list=$(cd "${PATCH_WRKSRC}" && \ > find -s * -type f -name '*.orig' 2>/dev/null) > - (cd ${PATCH_WRKSRC} && for F in ${new_list}; do > + (cd "${PATCH_WRKSRC}" && for F in ${new_list}; do I've sent John a slighly more complete patch which quotes all five invocations of "cd". You might consider quoting remaining tree as well (file $filesdir is less likely to contain spaces than $patch_wrksrc, it still might). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160121153124.GA15322>