From owner-svn-src-all@freebsd.org Thu Apr 20 16:08:42 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC1C5D4809B; Thu, 20 Apr 2017 16:08:42 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D24A01142; Thu, 20 Apr 2017 16:08:42 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v3KG8UZp036366; Thu, 20 Apr 2017 09:08:30 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v3KG8S7J036363; Thu, 20 Apr 2017 09:08:28 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201704201608.v3KG8S7J036363@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r317094 - head/share/mk In-Reply-To: <1934449.ZAthNnyNnu@ralph.baldwin.cx> To: John Baldwin Date: Thu, 20 Apr 2017 09:08:28 -0700 (PDT) CC: Ngie Cooper , Warner Losh , rgrimes@freebsd.org, Eric van Gyzen , Slawa Olhovchenkov , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 16:08:43 -0000 > On Wednesday, April 19, 2017 03:51:24 PM Ngie Cooper wrote: > > > > > On Apr 19, 2017, at 15:22, Warner Losh wrote: > > > > ... > > > > >> Actually this is exactly what I would expect from Linux! > > >> > > >> Why do we need to pull the trigger on GDB other than to pull the trigger > > >> to say we are GPL free, if that is the reason then this is the wrong > > >> way to go about it. > > > > > > I think "gdb in base is horribly broken" is the real reason. You need > > > the port to do anything non-trivial these days. Well it seems it can do some rather important trivial things, like post mortem process kernel dumps during savecore processing helping users submit a kernel panic bugzilla with more than just traceback info. Lets see.. we need to ship a full set of kernel symbols with a distribution, but now we are gona rip out the debugger??? > > > Plus core set this as a goal for the project after it was clear that > > > was a consensus desire several years ago. Can't fault someone for > > > working towards that goal. I do not think Core set this as a goal, the developers did it at a summit, and that was really only adding "by 12.0" to a goal that has been with the project since... well.. 1.0! Removing gdb by calling it a port does not achive the desired goal, it simply makes our base system lacking a kernel debugger and oh, you have to go install port foo to get back what we have been shipping for 25 years, but look, we are GPL free!! Bullocks. > > +1 to Warner's sentiments. > > > > gdb in base doesn't work well with threads (6.x never did ;/..), and lacks support for other things (like python debugging). Being able to debug threads reliably is a make or break thing. > > > > So while I understand and in general agree with you Rod, I completely disagree on the practical end of things. I'm actually kind of curious as to why this isn't being done globally.. but I assume that it was described in one of the many threads some time ago about the status quo for debugging with gdb on tier-two architectures. This is not about debugging python or debugging threads, this is about kernel panics and post mortem processing of a crash dump so a user can submit a more detailed crash than just a trace back from the panic. > > As the commit message stated, gdb in ports doesn't yet include kgdb > support for ARM, and no one has tested the sparc64 support for gdb > in ports, so those two architectures remain on. For all other platforms, > gdb in ports is a strict superset of gdb in base. So in effect we are providing gdb in base for kgdb support of ARM and sparc but removing it from i386 and amd64, stopping things that worked in the name of what? This does not make us any closer to gpl free, breaks functional stuff, and makes us more like Linux and less like FreeBSD (no kernel debugger in base system). If this is a GPL free issue we could of done this with all the GPL code 20 years ago... I see no upside to this change, where is the upside? -- Rod Grimes rgrimes@freebsd.org