From owner-p4-projects@FreeBSD.ORG  Sun Dec 10 23:59:45 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9B54616A4A0; Sun, 10 Dec 2006 23:59:45 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 691E716A4FF
	for <perforce@freebsd.org>; Sun, 10 Dec 2006 23:59:45 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 091A643CAC
	for <perforce@freebsd.org>; Sun, 10 Dec 2006 23:57:40 +0000 (GMT)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kBANwrnk073163
	for <perforce@freebsd.org>; Sun, 10 Dec 2006 23:58:53 GMT
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kBANwrrV073160
	for perforce@freebsd.org; Sun, 10 Dec 2006 23:58:53 GMT
	(envelope-from sam@freebsd.org)
Date: Sun, 10 Dec 2006 23:58:53 GMT
Message-Id: <200612102358.kBANwrrV073160@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 111420 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Dec 2006 23:59:45 -0000

http://perforce.freebsd.org/chv.cgi?CH=111420

Change 111420 by sam@sam_ebb on 2006/12/10 23:58:11

	cleanup (and correct) comments about why the default
	pllconfig is ext66

Affected files ...

.. //depot/projects/crypto/sys/dev/hifn/hifn7751.c#6 edit

Differences ...

==== //depot/projects/crypto/sys/dev/hifn/hifn7751.c#6 (text+ko) ====

@@ -296,19 +296,11 @@
  * bus clock and in a 33MHz slot then it will be operating at half
  * speed until the correct information is provided.
  *
- * According Mike Ham of HiFn, almost every board in existence has
- * an external crystal populated at 66Mhz. Using PCI can be a problem
- * on modern motherboards, because PCI33 can have clocks from 0 to 33Mhz,
- * and some have non-PCI-compliant spread-spectrum clocks, which can confuse
- * the pll.
- *
- * On Linux, there is no way to set pllconfig except on the boot
- * command line for static kernels. Even though the string can get adjusted
- * afterwards, the device will not be reconfigured.
- *
- * On FreeBSD, you can edit the device hints by editing /boot/device.hints,
- * and this too, is loaded only at boot time. See device.hints(5).
- *
+ * We use a default setting of "ext66" because according to Mike Ham
+ * of HiFn, almost every board in existence has an external crystal
+ * populated at 66Mhz. Using PCI can be a problem on modern motherboards,
+ * because PCI33 can have clocks from 0 to 33Mhz, and some have
+ * non-PCI-compliant spread-spectrum clocks, which can confuse the pll.
  */
 static void
 hifn_getpllconfig(device_t dev, u_int *pll)