From owner-cvs-all@FreeBSD.ORG Sat Mar 6 00:22:02 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D68C16A4CE; Sat, 6 Mar 2004 00:22:02 -0800 (PST) Received: from mtaw6.prodigy.net (mtaw6.prodigy.net [64.164.98.56]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4126E43D2D; Sat, 6 Mar 2004 00:22:02 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (c0379894125e8a68199ab762007ddfbe@adsl-67-119-53-203.dsl.lsan03.pacbell.net [67.119.53.203]) by mtaw6.prodigy.net (8.12.10/8.12.10) with ESMTP id i268L3a3011281; Sat, 6 Mar 2004 00:21:04 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id DC4765187D; Sat, 6 Mar 2004 00:22:00 -0800 (PST) Date: Sat, 6 Mar 2004 00:22:00 -0800 From: Kris Kennaway To: Joe Marcus Clarke Message-ID: <20040306082200.GA27791@xor.obsecurity.org> References: <200403060733.i267XKd3044611@repoman.freebsd.org> <20040306081037.GA27564@xor.obsecurity.org> <1078561060.30101.3.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline In-Reply-To: <1078561060.30101.3.camel@shumai.marcuscom.com> User-Agent: Mutt/1.4.2.1i cc: cvs-ports@FreeBSD.org cc: ports-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Kris Kennaway Subject: Re: cvs commit: ports/www/mplayer-plugin Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2004 08:22:02 -0000 --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 06, 2004 at 03:17:40AM -0500, Joe Marcus Clarke wrote: > On Sat, 2004-03-06 at 03:10, Kris Kennaway wrote: > > On Fri, Mar 05, 2004 at 11:33:20PM -0800, Joe Marcus Clarke wrote: > > > marcus 2004/03/05 23:33:20 PST > > >=20 > > > FreeBSD ports repository > > >=20 > > > Modified files: > > > www/mplayer-plugin Makefile=20 > > > Log: > > > Add firefox support via WITH_MOZILLA=3Dfirefox. Note: this only wo= rks for > > > mplayer-plugin. Setting WITH_MOZILLA=3Dfirefox will not work with = the > > > galeon ports. > >=20 > > Shouldn't this be WITH_FIREFOX=3Dyes or similar? Most WITH_ and > > WITHOUT_ variables do not care about the value, and giving them > > special values makes it difficult to use with configuration tools like > > 'make config'. >=20 > This was done for scaling purposes in the original Mozilla-based ports > (galeon, galeon2, epiphany). This way, one can specify the mozilla they > want to use (be it mozilla, mozilla-devel, and one point mozilla-vendor, > and now firefox). It was easier than defining a large number of macros > then deciding on precedence. OK, going this way, there is precedence for a MOZILLA_PORT variable (cf APACHE_PORT, GHOSTSCRIPT_PORT) for choosing one of a number of equivalent choices. kris --zhXaljGHf11kAtnf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFASYooWry0BWjoQKURAptMAJkBZ0gFaJf/1RAMUzMT73RULBQh2QCgptQD JjzgIaph4KBeqR5299GNdAA= =KrTx -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf--