From owner-dev-commits-ports-main@freebsd.org Thu Jul 15 14:38:57 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 95A16667FA9; Thu, 15 Jul 2021 14:38:57 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GQcSd3P2cz3pXh; Thu, 15 Jul 2021 14:38:57 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from marvin.madpilot.net (host-87-19-3-78.retail.telecomitalia.it [87.19.3.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id CFC4921DAC; Thu, 15 Jul 2021 14:38:56 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: git: dc9bf7d64926 - main - net/asterisk*: Add aarch64 support To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202107141033.16EAX60T044972@gitrepo.freebsd.org> From: Guido Falsi Message-ID: <81bc6b76-7b74-9990-d7dc-54ca14b0ee4f@FreeBSD.org> Date: Thu, 15 Jul 2021 16:38:53 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 14:38:57 -0000 On 15/07/21 04:06, Alexey Dokuchaev wrote: > On Wed, Jul 14, 2021 at 10:33:06AM +0000, Guido Falsi wrote: >> commit dc9bf7d649260fd6c1d3310b2077c3c98cd19c6a >> >> net/asterisk*: Add aarch64 support >> >> User testing reports asterisk compiles and works fine on aarch64. >> >> ... >> EXPIRATION_DATE=2021-10-24 >> >> -ONLY_FOR_ARCHS= amd64 armv6 armv7 i386 powerpc powerpc64 powerpc64le sparc64 >> +ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386 powerpc powerpc64 powerpc64le sparc64 > > I think ONLY_FOR_ARCHS here clearly outlived its purpose and can just > be removed. It arguably misses MIPS, but we aren't promising much for > that tier anyways, and this harness just gets in the way of those who > know that they're doing. After all, there shouldn't be anything > inherently architecture-specific about the telephony toolkit, but even > if there is, individual BROKEN_$arch would be more appropriate. > The fact that mips is not included is exactly the reason I did not remove ONLY_FOR_ARCHS. If what you say is the general consensus I'll be quite happy to get rid of it. For the record, asterisk used to fail on many architectures due to some C language constructs it uses which were not supported by older compilers in some cases, especially for more exotic architectures still using older compilers or less supported by the compilers being used. I guess this compiler mix situation is not an issue anymore. -- Guido Falsi