From owner-svn-src-all@FreeBSD.ORG Sun May 16 19:54:43 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 989A71065672; Sun, 16 May 2010 19:54:43 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-px0-f182.google.com (mail-px0-f182.google.com [209.85.212.182]) by mx1.freebsd.org (Postfix) with ESMTP id 5A8BA8FC08; Sun, 16 May 2010 19:54:42 +0000 (UTC) Received: by pxi7 with SMTP id 7so860374pxi.13 for ; Sun, 16 May 2010 12:54:42 -0700 (PDT) Received: by 10.141.124.3 with SMTP id b3mr2904972rvn.123.1274039682616; Sun, 16 May 2010 12:54:42 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.140.247.13 with HTTP; Sun, 16 May 2010 12:54:22 -0700 (PDT) In-Reply-To: <201005161943.o4GJhnTo096839@svn.freebsd.org> References: <201005161943.o4GJhnTo096839@svn.freebsd.org> From: Juli Mallett Date: Sun, 16 May 2010 12:54:22 -0700 X-Google-Sender-Auth: _jXcWiqN0hqDjkNSeNDAInP3sWQ Message-ID: To: Randall Stewart Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r208165 - in head/sys: kern mips/conf mips/include mips/mips mips/rmi mips/rmi/dev/xlr X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 May 2010 19:54:43 -0000 On Sun, May 16, 2010 at 12:43, Randall Stewart wrote: > Author: rrs > Date: Sun May 16 19:43:48 2010 > New Revision: 208165 > URL: http://svn.freebsd.org/changeset/base/208165 > > Log: > =A0This pushes all of JC's patches that I have in place. I > =A0am now able to run 32 cores ok.. but I still will hang > =A0on buildworld with a NFS problem. I suspect I am missing > =A0a patch for the netlogic rge driver. > > =A0JC check and see if I am missing anything except your > =A0core-mask changes This isn't a very good commit message. Commits communicate things going forward. A follow-up E-Mail CCing JC would have been a good way to chat with him about its completeness. More importantly, though, there's just no description of the contents. This is particularly frustrating as it's also not broken up into functional chunks very well. Given the fact that there are MI changes and pan-MIPS changes here it would be nice to see a little more care taken. The changes to the MIPS MP code, for instance, I thought we had discussed and decided were sub-par and easily made less invasive. I can't comment on the RMI-specific stuff except to say that it's an unenumerated jumble of VM, networking and SMP changes.