From owner-freebsd-current@freebsd.org Sat Dec 7 19:25:15 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1AF751CAAF6 for ; Sat, 7 Dec 2019 19:25:15 +0000 (UTC) (envelope-from trond.endrestol@ximalas.info) Received: from enterprise.ximalas.info (enterprise.ximalas.info [IPv6:2001:700:1100:1::8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "ximalas.info", Issuer "Hostmaster ximalas.info" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47VfYP5GJyz488Y; Sat, 7 Dec 2019 19:25:13 +0000 (UTC) (envelope-from trond.endrestol@ximalas.info) Received: from enterprise.ximalas.info (Ximalas@localhost [127.0.0.1]) by enterprise.ximalas.info (8.15.2/8.15.2) with ESMTPS id xB7JP1M9037170 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 7 Dec 2019 20:25:01 +0100 (CET) (envelope-from trond.endrestol@ximalas.info) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ximalas.info; s=default; t=1575746701; bh=d32uxgqHSd/89qjdV9E1xIWdQ8TRxueypfweKKbscj4=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=hrENpX8NgEhLMtCF/bFHMefXmpoot+TKBB7Oixs+MDTHjbN4GyN8XGPp/bRQuXOCs 6Ury+0eyp0OdXaZbI5ZtPo1ebglxz9fZEGMPkXEl2lfWYnjAlFgt4dK7ZJ5/Z9GcUi KB+pupgP29nstHrULKBDKGQtz6N9z9kWI23i2+f3qhTXCzTHL+VdTeOLZb/t+92Ko5 HZ8JMudw2eNX036neI+OLhn081f4frtxG//xjQPwd+SdjRUha52wZ0pLOe0V6KENRO tkZS4zKSaapgqN+aDoxWGOr2zpNRHFdhPHKDUqUgmgrPfFlH/CKzK+P/WWVDmJ91YA hpd81Wx1HhqnQ== Received: from localhost (trond@localhost) by enterprise.ximalas.info (8.15.2/8.15.2/Submit) with ESMTP id xB7JP1vL037167; Sat, 7 Dec 2019 20:25:01 +0100 (CET) (envelope-from trond.endrestol@ximalas.info) X-Authentication-Warning: enterprise.ximalas.info: trond owned process doing -bs Date: Sat, 7 Dec 2019 20:25:01 +0100 (CET) From: =?UTF-8?Q?Trond_Endrest=C3=B8l?= Sender: Trond.Endrestol@ximalas.info To: Michael Butler cc: dougm@freebsd.org, freebsd-current Subject: Re: SVN r355491 breaks libprocstat In-Reply-To: <99d71e40-b669-d7da-3163-7a74a7163660@protected-networks.net> Message-ID: References: <99d71e40-b669-d7da-3163-7a74a7163660@protected-networks.net> User-Agent: Alpine 2.21.99999 (BSF 352 2019-06-22) OpenPGP: url=http://ximalas.info/about/tronds-openpgp-public-key MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on enterprise.ximalas.info X-Rspamd-Queue-Id: 47VfYP5GJyz488Y X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ximalas.info header.s=default header.b=hrENpX8N; dmarc=pass (policy=none) header.from=ximalas.info; spf=pass (mx1.freebsd.org: domain of trond.endrestol@ximalas.info designates 2001:700:1100:1::8 as permitted sender) smtp.mailfrom=trond.endrestol@ximalas.info X-Spamd-Result: default: False [-4.93 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[ximalas.info:s=default]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ximalas.info:+]; DMARC_POLICY_ALLOW(-0.50)[ximalas.info,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:224, ipnet:2001:700::/32, country:NO]; IP_SCORE(-1.93)[ip: (-7.86), ipnet: 2001:700::/32(-1.14), asn: 224(-0.66), country: NO(-0.01)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Dec 2019 19:25:15 -0000 On Sat, 7 Dec 2019 12:57-0500, Michael Butler wrote: > This member removal has other consequences. As follows .. > > --- lib/libprocstat__L --- > Building /usr/obj/usr/src/amd64.amd64/lib/libprocstat/smbfs.o > --- libprocstat.o --- > /usr/src/lib/libprocstat/libprocstat.c:620:29: error: no member named > 'next' in 'struct vm_map_entry' > for (entryp = map->header.next; > ~~~~~~~~~~~ ^ > /usr/src/lib/libprocstat/libprocstat.c:622:24: error: no member named > 'next' in 'struct vm_map_entry' > entryp = vmentry.next) { > ~~~~~~~ ^ > 2 errors generated. Now we seem to be missing the prototypes: --- libprocstat.o --- /usr/src/lib/libprocstat/libprocstat.c:620:17: error: implicit declaration of function 'vm_map_entry_first' is invalid in C99 [-Werror,-Wimplicit-function-declaration] for (entryp = vm_map_entry_first(map); ^ /usr/src/lib/libprocstat/libprocstat.c:620:15: error: incompatible integer to pointer conversion assigning to 'vm_map_entry_t' (aka 'struct vm_map_entry *') from 'int' [-Werror,-Wint-conversion] for (entryp = vm_map_entry_first(map); ^ ~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/lib/libprocstat/libprocstat.c:622:16: error: implicit declaration of function 'vm_map_entry_succ' is invalid in C99 [-Werror,-Wimplicit-function-declaration] entryp = vm_map_entry_succ(&vmentry)) { ^ /usr/src/lib/libprocstat/libprocstat.c:622:16: note: did you mean 'vm_map_entry_first'? /usr/src/lib/libprocstat/libprocstat.c:620:17: note: 'vm_map_entry_first' declared here I'm at r355504. -- Trond.