From owner-freebsd-net@freebsd.org Thu Feb 20 13:59:50 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A5017239B93 for ; Thu, 20 Feb 2020 13:59:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48NbnL3NFCz4618 for ; Thu, 20 Feb 2020 13:59:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 73522239B92; Thu, 20 Feb 2020 13:59:50 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7300D239B90 for ; Thu, 20 Feb 2020 13:59:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48NbnL2LjFz460q for ; Thu, 20 Feb 2020 13:59:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4AFA522BFF for ; Thu, 20 Feb 2020 13:59:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 01KDxoC6062163 for ; Thu, 20 Feb 2020 13:59:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 01KDxoU8062162 for net@FreeBSD.org; Thu, 20 Feb 2020 13:59:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 244241] ng_eiface: panic: epoch_wait_preempt() called in the middle of an epoch section of the same epoch Date: Thu, 20 Feb 2020 13:59:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: aleksandr.fedorov@itglobal.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Feb 2020 13:59:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244241 --- Comment #2 from Aleksandr Fedorov --- Yes, it seems that netgraph needs some love. In this case, the function ngc_send() entering to the epoch. So, this is the control path, not data. Data path enter to the epoch from ngthread(), ng_callout_trampoline() and if node really need it: http://bxr.su/FreeBSD/sys/netgraph/ng_base.c#3423 http://bxr.su/FreeBSD/sys/netgraph/ng_base.c#3778 http://bxr.su/FreeBSD/sys/netgraph/ng_device.c#475 After a quick research (http://bxr.su/search?q=3DNET_EPOCH_ENTER&defs=3D&refs=3D&path=3Dsys%2Fnetg= raph&project=3DFreeBSD): 1. http://bxr.su/FreeBSD/sys/netgraph/ng_ip_input.c#131 - already in epoch. 2. http://bxr.su/FreeBSD/sys/netgraph/ng_ether.c#601 - already in epoch. 3. http://bxr.su/FreeBSD/sys/netgraph/ng_ether.c#743 - already in epoch. 4. http://bxr.su/FreeBSD/sys/netgraph/ng_eiface.c#517 - already in epoch. 5. http://bxr.su/FreeBSD/sys/netgraph/ng_iface.c#735 - already in epoch. Do we really need to entering the epoch from control path? http://bxr.su/FreeBSD/sys/netgraph/ng_socket.c#341 --=20 You are receiving this mail because: You are the assignee for the bug.=