From owner-freebsd-bugs Mon Oct 15 13:40:13 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 992AB37B408 for ; Mon, 15 Oct 2001 13:40:10 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id f9FKeAp48036; Mon, 15 Oct 2001 13:40:10 -0700 (PDT) (envelope-from gnats) Date: Mon, 15 Oct 2001 13:40:10 -0700 (PDT) Message-Id: <200110152040.f9FKeAp48036@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: "Crist J. Clark" Subject: Re: bin/31199: tunefs error is incorrect when enabling softupdates Reply-To: "Crist J. Clark" Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/31199; it has been noted by GNATS. From: "Crist J. Clark" To: Bruce Evans Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: bin/31199: tunefs error is incorrect when enabling softupdates Date: Mon, 15 Oct 2001 13:38:34 -0700 On Tue, Oct 16, 2001 at 01:22:37AM +1000, Bruce Evans wrote: > On Mon, 15 Oct 2001, Crist J. Clark wrote: [snip] > > The messages should reflect that it is collecting the values > > before it actually tries to write them. Something more like, > > > > $ tunefs -n enable /dev/ad0s1a > > tunefs: setting soft updates... > > tunefs: cannot open /dev/ad0s1a: Permission denied > > The "setting" message used to be "soft updates set". I changed this to > "soft updates changes from disabled to enabled" (and similarly for > "soft updates cleared" so that the wording is similar for all the messages. OK. Probably better. This hasn't been committed yet, though? > > And in a successful run (since tunefs(8) is already chatty on > > success), > > > > $ tunefs -n enable /dev/ad0s1a > > tunefs: setting soft updates... > > tunefs: changes on /dev/ad0s1 done > > The "changes done" message is silly if tunefs has only printed "remains > unchanged" messages. But then again, even if there are no changes, tunefs(8) unconditionally writes the "modified" data. -- Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message