From owner-svn-src-all@freebsd.org Thu May 9 17:27:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 358921588B24; Thu, 9 May 2019 17:27:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A7F2871461; Thu, 9 May 2019 17:27:12 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x42c.google.com with SMTP id t87so1677226pfa.2; Thu, 09 May 2019 10:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4ZEE3js+BECroBMxIMi5vcXsMsWm8TVRwlLj48nVLa0=; b=LeuXhQ/8wOS4TCC6d0DPcAp1+2c5dvPeX1WogK9rt+iWtHPl/3QAZ4cYhmmXSE6h6o +/luw3k/oWOLMhycc4g63OLRcm8LhOg9OdiH2ROZMk/A2G8Lm/tCPPN5cBb0q/HUmG/6 OJ2l7Yj3aWRDawlA3lWp9eHnA3mnmInRmiiKD9Y3Z3MOejzt5gDQWyQ4YcY3BcfbmMBx z1btKwB4qdcGuLPtx12Q3X3Zq2+SgFem7xM8iVngQlYl9oHyuoMQESUozd9tUPiqIboI 7CycLE9qVtBDOIygyTyfh8u0i5BAmSS0rZ7HtaMeJUhKxmaQHPLSpA/xWfNfqg/KrN5g tkHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4ZEE3js+BECroBMxIMi5vcXsMsWm8TVRwlLj48nVLa0=; b=nfvVNdh5q+PchUxik/ax0icGBD4QUtpQncUjEumWSFMG57w+tl0wDLOND8O+cB/oRK sYI3ZyQnmQJYLvnH/K+0TzHbtFPVkoDSIMzp5c8YkE7zIY4i2GjT2fo5iTGLdtcIqjBZ TwA3xDhP74aqxJ94k7trer77it+T4HFFmKYHgQXVPtR86OxpCkC7NvADbqsMf9kObkWB mVt4EOVDRopi90MASPo/TfBE4K5N6MmYRCD+8hur/k/qI5PQNUKj6nWjDVP9N0YPQVrp CWxle3oILpT9uzsLyV+tXKtVeh2wFow8If8GQGkDs8ew6/fdwT5VacCzPsWQYBBrm1Fy vpVA== X-Gm-Message-State: APjAAAX0m7hShtR1m09z6RmQqPnEAPo0aSXkWxP4zLu+s0ZJcUvjQFNF r+Kh4ccPIkIAlwYzmUUw/k/CpFi+Ow0= X-Google-Smtp-Source: APXvYqxoikhP31MyAjRiUyeso9NttN5YWHFOcLB/g1v0f+wBKX4il/QlWP7xa6RDhYmXsxDzK8hbzA== X-Received: by 2002:a62:14d6:: with SMTP id 205mr7002848pfu.4.1557422831026; Thu, 09 May 2019 10:27:11 -0700 (PDT) Received: from [192.168.20.21] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id q10sm2964525pgh.93.2019.05.09.10.27.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 10:27:10 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: svn commit: r347392 - head/sbin/ifconfig From: "Enji Cooper (yaneurabeya)" In-Reply-To: <201905091258.x49CwYr0095200@repo.freebsd.org> Date: Thu, 9 May 2019 10:27:09 -0700 Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201905091258.x49CwYr0095200@repo.freebsd.org> To: Kyle Evans X-Mailer: Apple Mail (2.3445.104.8) X-Rspamd-Queue-Id: A7F2871461 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.952,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 17:27:13 -0000 > On May 9, 2019, at 05:58, Kyle Evans wrote: >=20 > Author: kevans > Date: Thu May 9 12:58:33 2019 > New Revision: 347392 > URL: https://svnweb.freebsd.org/changeset/base/347392 >=20 > Log: > ifconfig(8): Partial revert of r347241 >=20 > r347241 introduced an ifname <-> kld mapping table, mostly so = tun/tap/vmnet > can autoload the correct module on use. It also inadvertently made = bogus > some previously valid uses of sizeof(). >=20 > Revert back to ifkind on the stack for simplicity sake. This reduces = the > diff from the previous version of ifmaybeload for easiser auditing. Hi Kyle, Thank you for this revert. This change fixed the FreeBSD test = suite runs, which are once again green after this change. A number of = tests which use ifconfig were failing because they couldn=E2=80=99t = configure interfaces: = https://ci.freebsd.org/job/FreeBSD-head-amd64-test/11134/testReport/ .=20= Cheers! -Enji=