From owner-svn-src-all@freebsd.org  Fri Aug 14 12:16:56 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C1A199FD45;
 Fri, 14 Aug 2015 12:16:56 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8900D1DA0;
 Fri, 14 Aug 2015 12:16:55 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t7ECGoCF067772
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Fri, 14 Aug 2015 15:16:50 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t7ECGoCF067772
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id t7ECGotb067771;
 Fri, 14 Aug 2015 15:16:50 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Fri, 14 Aug 2015 15:16:50 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Pedro Giffuni <pfg@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r286760 - in head/lib/libc: . secure sys
Message-ID: <20150814121649.GN2072@kib.kiev.ua>
References: <201508140303.t7E33EnN095618@repo.freebsd.org>
 <20150814112443.GL2072@kib.kiev.ua>
 <85D0049C-488D-45E3-8E60-8F9442CFC8B2@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <85D0049C-488D-45E3-8E60-8F9442CFC8B2@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Aug 2015 12:16:56 -0000

On Fri, Aug 14, 2015 at 07:02:25AM -0500, Pedro Giffuni wrote:
> Hello;
> 
> > Il giorno 14/ago/2015, alle ore 06:24, Konstantin Belousov <kostikbel@gmail.com> ha scritto:
> > 
> > On Fri, Aug 14, 2015 at 03:03:14AM +0000, Pedro F. Giffuni wrote:
> >> +/*
> >> + * It'd be nice to have this automatically generated, but we don't
> >> + * know to what version they will eventually belong, so for now
> >> + * it has to be manual.
> >> + */
> > The comment does not make a bit of sense.
> > It also raises the question whether the author(s) of the change
> > ever understand what do they change.
> > 
> 
> It was blindly copy/pasted from the originating lib/libc/sys/Symbol.map.
In the sys/Symbol.map it referenced the generated symbols for the
syscall trampolines. You could clarify this in the comment, by limiting
its scope to the syscall symbols. But I do not object to removing it
from sys/Symbol.map.

> 
> I will remove both stale comments.
Ok.