From owner-freebsd-fs  Tue Jun 27  6:49:35 2000
Delivered-To: freebsd-fs@freebsd.org
Received: from hetnet.nl (net015s.hetnet.nl [194.151.104.155])
	by hub.freebsd.org (Postfix) with ESMTP id BD0C437BB1B
	for <freebsd-fs@freebsd.org>; Tue, 27 Jun 2000 06:49:27 -0700 (PDT)
	(envelope-from leonardjo@hetnet.nl)
Received: from potkoffie ([195.121.129.134]) by hetnet.nl  with Microsoft SMTPSVC(5.5.1877.387.38);
	 Tue, 27 Jun 2000 15:49:24 +0200
From: "Leonard den Ottolander" <leonardjo@hetnet.nl>
To: Sascha Schumann <sascha@schumann.cx>
Date: Tue, 27 Jun 2000 15:47:53 +0200
MIME-Version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Subject: Re: Again:Patch concerning linux extended fs
Cc: freebsd-fs@freebsd.org
References: <077090602151860NET015S@hetnet.nl>
In-reply-to: <Pine.LNX.4.21.0006241719510.22839-100000@eco.foo>
X-mailer: Pegasus Mail for Win32 (v3.01d)
Message-ID: <08ac62449131b60NET015S@hetnet.nl>
Sender: owner-freebsd-fs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

		Hi Sascha,

>     Instead of changing all checks everytime, you might want to
>     use a macro:
> 
>     #define IS_DOS_EXTENDED_PARTITION(n)                \
>         (n == DOSPTYP_EXTENDED                          \
>             || n == DOSPTYP_EXTENDEDX                   \
>             || n == DOSPTYP_LINUXEXTENDED)

 If you check the Linux fdisk.h (fe util-linux 2.9w), you will see that they 
indeed use a very similair (almost identical) macro. One thing though, it is 
more correct to put braces around the n's, in case (n) is a compound element. 
This should actually be done in any macro, to prevent errors.
 You could of course have submitted this to the list yourself, since it is not 
just my concern! I will include it before I do a PR submission.

				Thanks anyway,

				Leonard.



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-fs" in the body of the message