Date: Tue, 27 Jun 2000 15:47:53 +0200 From: "Leonard den Ottolander" <leonardjo@hetnet.nl> To: Sascha Schumann <sascha@schumann.cx> Cc: freebsd-fs@freebsd.org Subject: Re: Again:Patch concerning linux extended fs Message-ID: <08ac62449131b60NET015S@hetnet.nl> In-Reply-To: <Pine.LNX.4.21.0006241719510.22839-100000@eco.foo> References: <077090602151860NET015S@hetnet.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Sascha, > Instead of changing all checks everytime, you might want to > use a macro: > > #define IS_DOS_EXTENDED_PARTITION(n) \ > (n == DOSPTYP_EXTENDED \ > || n == DOSPTYP_EXTENDEDX \ > || n == DOSPTYP_LINUXEXTENDED) If you check the Linux fdisk.h (fe util-linux 2.9w), you will see that they indeed use a very similair (almost identical) macro. One thing though, it is more correct to put braces around the n's, in case (n) is a compound element. This should actually be done in any macro, to prevent errors. You could of course have submitted this to the list yourself, since it is not just my concern! I will include it before I do a PR submission. Thanks anyway, Leonard. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?08ac62449131b60NET015S>