Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Oct 2015 13:15:01 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 204005] [patch][pf] PF_ANEQ macro improperly compare IPv4 packets.
Message-ID:  <bug-204005-8-wpiWFLzZM0@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-204005-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-204005-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204005

--- Comment #1 from commit-hook@freebsd.org ---
A commit references this bug:

Author: kp
Date: Sun Oct 25 13:14:54 UTC 2015
New revision: 289932
URL: https://svnweb.freebsd.org/changeset/base/289932

Log:
  PF_ANEQ() macro will in most situations returns TRUE comparing two identical
  IPv4 packets (when it should return FALSE). It happens because PF_ANEQ()
doesn't
  stop if first 32 bits of IPv4 packets are equal and starts to check next 3*32
  bits (like for IPv6 packet). Those bits containt some garbage and in result
  PF_ANEQ() wrongly returns TRUE.

  Fix: Check if packet is of AF_INET type and if it is then compare only first
32
  bits of data.

  PR:        204005
  Submitted by:    Mi?osz Kaniewski

Changes:
  head/sys/net/pfvar.h

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204005-8-wpiWFLzZM0>