From owner-freebsd-current Wed May 30 1:59:40 2001 Delivered-To: freebsd-current@freebsd.org Received: from granger.mail.mindspring.net (granger.mail.mindspring.net [207.69.200.148]) by hub.freebsd.org (Postfix) with ESMTP id 4C46837B424 for ; Wed, 30 May 2001 01:59:36 -0700 (PDT) (envelope-from tlambert2@mindspring.com) Received: from mindspring.com (pool0246.cvx7-bradley.dialup.earthlink.net [209.178.164.246]) by granger.mail.mindspring.net (8.9.3/8.8.5) with ESMTP id EAA19787; Wed, 30 May 2001 04:59:31 -0400 (EDT) Message-ID: <3B14B68D.B7FEA305@mindspring.com> Date: Wed, 30 May 2001 01:59:57 -0700 From: Terry Lambert Reply-To: tlambert2@mindspring.com X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Brooks Davis Cc: Terry Lambert , current@FreeBSD.ORG Subject: Re: PATCH: media option for ethernet hw checksum References: <200105252311.QAA05152@usr02.primenet.com> <20010525163729.A18559@Odin.AC.HMC.Edu> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Brooks Davis wrote: > > On Fri, May 25, 2001 at 11:11:16PM +0000, Terry Lambert wrote: > > Here is a patch I have locally that would be useful for Bill Paul, > > I think. I know, we could use "flag0" for this, but it seems to > > me that this will be an increasingly common option in hadware. > > Should this be implemented as a shared option like this? I > ask because NetBSD has added the following types and only > has one shared option left: > > #define IFM_FLOW 0x00400000 /* enable hardware flow control */ > #define IFM_FLAG0 0x01000000 /* Driver defined flag */ > #define IFM_FLAG1 0x02000000 /* Driver defined flag */ > #define IFM_FLAG2 0x04000000 /* Driver defined flag */ > #define IFM_LOOP 0x08000000 /* Put hardware in loopback */ > > Personaly I don't think I would have wasted 3/8th of the > shared options on the abomination known as flags... Flags can be device private, which can be a good thing. I only use the patch because I know of no Gigabit ethernet cards that are useful which can not perform checksum offloading. Maybe it should just always be on... I thought there was a problem with performance, doing that with the Tigon II. In any case, it seems to be a tradeoff that you might want to make intentionally, if your main processor was 1.5GHz... -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message