From owner-freebsd-net@FreeBSD.ORG Thu Mar 15 11:15:14 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0862B16A405; Thu, 15 Mar 2007 11:15:14 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id DFD0413C46C; Thu, 15 Mar 2007 11:15:12 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l2FBF40P030690; Thu, 15 Mar 2007 14:15:04 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l2FBF4da030689; Thu, 15 Mar 2007 14:15:04 +0300 (MSK) (envelope-from yar) Date: Thu, 15 Mar 2007 14:15:03 +0300 From: Yar Tikhiy To: Brooks Davis Message-ID: <20070315111503.GD28354@comp.chem.msu.su> References: <20070314102023.GB1766@comp.chem.msu.su> <20070314150138.GC56444@lor.one-eyed-alien.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070314150138.GC56444@lor.one-eyed-alien.net> User-Agent: Mutt/1.5.9i Cc: freebsd-net@freebsd.org Subject: Re: Generic ioctl and ether_ioctl don't agree X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2007 11:15:14 -0000 On Wed, Mar 14, 2007 at 10:01:38AM -0500, Brooks Davis wrote: > On Wed, Mar 14, 2007 at 01:20:23PM +0300, Yar Tikhiy wrote: > > Hi folks, > > > > Quite a while ago I noticed that our ioctl handlers get the ioctl > > command via u_long, but ether_ioctl()'s command argument is int. > > This disarray dates back to 1998, when ioctl functions started to > > take u_long as the command, but ether_ioctl() was never fixed. > > Fortunately, our ioctl command coding still fits in 32 bits, or > > else we would've got problems on 64-bit arch'es already. I'd like > > to fix this long-standing bug some day after RELENG_7 is branched. > > Of course, this will break ABI to network modules on all 64-bit > > arch'es. BTW, the same applies to other L2 layers, such as firewire, > > which seems to have been cloned from if_ethersubr.c. > > > > Any objections or comments? Thanks! > > Why wait? We're allowed to break module ABIs in current at any time and > there's no chance modules built on RELENG_6 will work on RELENG_7 > trees anyway. Perhaps I was over-conservative. :-) -- Yar