From owner-cvs-all@FreeBSD.ORG  Fri Jun 15 23:45:40 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A986B16A468;
	Fri, 15 Jun 2007 23:45:40 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 8319413C48A;
	Fri, 15 Jun 2007 23:45:40 +0000 (UTC) (envelope-from bz@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l5FNjeOL035615;
	Fri, 15 Jun 2007 23:45:40 GMT (envelope-from bz@repoman.freebsd.org)
Received: (from bz@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l5FNje1U035601;
	Fri, 15 Jun 2007 23:45:40 GMT (envelope-from bz)
Message-Id: <200706152345.l5FNje1U035601@repoman.freebsd.org>
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
Date: Fri, 15 Jun 2007 23:45:39 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/netipsec key.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2007 23:45:40 -0000

bz          2007-06-15 23:45:39 UTC

  FreeBSD src repository

  Modified files:
    sys/netipsec         key.c 
  Log:
  Add a missing return so that we drop out in case of an error and
  do not continue with a NULL pointer. [1]
  
  While here change the return of the error handling code path above.
  I cannot see why we should always return 0 there. Neither does KAME
  nor do we in here for the similar check in all the other functions.
  
  Found with:     Coverity Prevent(tm) [1]
  CID:            2521
  
  Revision  Changes    Path
  1.25      +2 -3      src/sys/netipsec/key.c