Date: Mon, 1 Feb 2021 14:52:29 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: e92ab3adf4f9 - stable/13 - atomic: make atomic_store_ptr type-aware Message-ID: <20583f6b-338b-21d6-5ae9-3e56488340d2@selasky.org> In-Reply-To: <202102011240.111CehGE094845@gitrepo.freebsd.org> References: <202102011240.111CehGE094845@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/1/21 1:40 PM, Mateusz Guzik wrote: > #define atomic_store_ptr(p, v) \ > - (*(volatile uintptr_t *)(p) = (uintptr_t)(v)) > + (*(volatile __typeof(*p) *)(p) = (v)) Are you missing an assert here? CASSERT(sizeof(*p) == sizeof(void *)); The way I read it atomic_store_ptr() can now store any type? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20583f6b-338b-21d6-5ae9-3e56488340d2>