From owner-svn-src-all@freebsd.org Fri Mar 9 15:52:13 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58DDDF33861; Fri, 9 Mar 2018 15:52:13 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B65F7D5F9; Fri, 9 Mar 2018 15:52:12 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w29FqAc3065078; Fri, 9 Mar 2018 07:52:10 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w29FqAWo065077; Fri, 9 Mar 2018 07:52:10 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201803091552.w29FqAWo065077@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r330696 - in head/libexec/tftpd: . tests In-Reply-To: <201803091530.w29FUKin041283@repo.freebsd.org> To: Alan Somers Date: Fri, 9 Mar 2018 07:52:10 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 15:52:13 -0000 > Author: asomers > Date: Fri Mar 9 15:30:20 2018 > New Revision: 330696 > URL: https://svnweb.freebsd.org/changeset/base/330696 > > Log: > Add some functional tests for tftpd(8) > > tftpd(8) is difficult to test in isolation due to its relationship with > inetd. Create a test program that mimics the behavior of tftp(1) and > inetd(8) and verifies tftpd's response in several different scenarios. At one time I thought it was possible to run all of the external "inetd" daemons as standalone daemons without inetd involved. I do not recall if tftpd was included in that, but believe it was. I am sure that telnetd and ftpd would run standalone. Have we lost some useful functionality here that maybe we want back? > These test cases cover all of the basic TFTP protocol, but not the optional > parts. > > PR: 157700 > PR: 225996 > PR: 226004 > PR: 226005 > MFC after: 3 weeks > Differential Revision: https://reviews.freebsd.org/D14310 ... -- Rod Grimes rgrimes@freebsd.org