From owner-freebsd-current@freebsd.org Tue Nov 6 09:50:21 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69EDC110DC7C for ; Tue, 6 Nov 2018 09:50:21 +0000 (UTC) (envelope-from sg@efficientip.com) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8221C6F4DF for ; Tue, 6 Nov 2018 09:50:20 +0000 (UTC) (envelope-from sg@efficientip.com) Received: by mail-ed1-x533.google.com with SMTP id x2-v6so9953268eds.3 for ; Tue, 06 Nov 2018 01:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientip.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=QscN3sz5bTPMn7nzJ/LcEwdWHwAY3Vethea3br7+Jms=; b=qeglj6KNePbMPK9iXnKVLogNjFNIDzlcruFVWy7ytmsR3Rmf+TEeAT0p7GMXBVHDtm O8UpA2MICeWWwJpI1T/M81GIGX9C3Vo6zCXLFsrbrauX4UkudeVDUe1iiDDJdpIAX7Vk 8TiCbsoB7OHbdabb7SndR1LmGW7F5Sa4LECTg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=QscN3sz5bTPMn7nzJ/LcEwdWHwAY3Vethea3br7+Jms=; b=BM4J0P4k/LIoYyAn+u6Ml07eFavvChuwmuVSayTaDIB3X/pQIH24j7E0DIA54+NGF5 3DmUcpcOFJnPJ/NV5Tyetplg4qLevcuiPxCGCIiZAT/idG8otmDq1pfm527xmSLxQTnK gIXJE/i21/mI8EIwvTlO/TWr5fIWvFDD20hOqBRlnuiWH/DAFbfgSbU53yyiXCbn8nSv tDe1pJ79XMhgQm6JDBcPYXgyMIyNhWwIENlGd1ZIGhB5LNnOSewyyfKo/qV7KL8ZA57q 9c/AkHTKDeejMDEvywIHpSYbxBeg+reouFAA2wyE59PowFNQDbo69dzkdbDkNsGW7BiQ R/Vw== X-Gm-Message-State: AGRZ1gJCSkYd9RDAeac9WK2rdxUGP165vGN7N65xpl5r3hSx2NfWU/nB SyClP3k3798C0DR5dfVDcitigjVphmiKbqle7zLi9VMfzDYomQ== X-Google-Smtp-Source: AJdET5fbMmUtEWr4m6awONWRA1ucNzNCOM7vTbAZHLwtJ9rreErreok/jL1lgU3WDuJbOc5TYChtKvXsETDR13u1PCY= X-Received: by 2002:a50:8987:: with SMTP id g7-v6mr19857674edg.257.1541497819142; Tue, 06 Nov 2018 01:50:19 -0800 (PST) MIME-Version: 1.0 From: Sylvain GALLIANO Date: Tue, 6 Nov 2018 10:50:06 +0100 Message-ID: Subject: Panic on kern_event.c To: freebsd-current@freebsd.org X-Rspamd-Queue-Id: 8221C6F4DF X-Spamd-Result: default: False [-5.62 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.977,0]; R_DKIM_ALLOW(-0.20)[efficientip.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.992,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[efficientip.com]; DKIM_TRACE(0.00)[efficientip.com:+]; MX_GOOD(-0.01)[alt1.aspmx.l.google.com,aspmx.l.google.com,aspmx5.googlemail.com,aspmx4.googlemail.com,aspmx3.googlemail.com,alt2.aspmx.l.google.com,aspmx2.googlemail.com]; RCVD_IN_DNSWL_NONE(0.00)[3.3.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.88)[-0.882,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.46)[ip: (-8.81), ipnet: 2a00:1450::/32(-1.93), asn: 15169(-1.47), country: US(-0.08)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 09:50:21 -0000 Hi, I got random panic on Current & 11.2-STABLE on kern_event.c Panic occur in syslog-ng (logging at high rate) with the folloging lines: Panic String: Bad tailq NEXT(0xfffff80039ae7a38->tqh_last) != NULL Panic String: Bad tailq head 0xfffff80039f1a238 first->prev != head It's look like knote_enqueue try to add and existings knote on TAILQ (confirmed by following patch). logs after apply patch: XXX knote 0xfffff8012e3d33c0 already in tailq status:1 kq_count:1 [0 0xfffff800327d3538] 2671 XXX knote 0xfffff80032861780 already in tailq status:1 kq_count:1 [0 0xfffff80032457938] 2671 =================================================================== --- sys/kern/kern_event.c (revision 340175) +++ sys/kern/kern_event.c (working copy) @@ -2661,10 +2661,18 @@ knote_enqueue(struct knote *kn) { struct kqueue *kq = kn->kn_kq; + struct knote *ttkn; KQ_OWNED(kn->kn_kq); KASSERT((kn->kn_status & KN_QUEUED) == 0, ("knote already queued")); + TAILQ_FOREACH(ttkn, &kq->kq_head, kn_tqe) { + if (ttkn == kn) { + printf("XXX knote %p already in tailq status:%x kq_count:%d [%p %p] %u\n",kn,kn->kn_status,kq->kq_count,kn->kn_tqe.tqe_next,kn->kn_tqe.tqe_prev,__LINE__); + return; + } + } + TAILQ_INSERT_TAIL(&kq->kq_head, kn, kn_tqe); kn->kn_status |= KN_QUEUED; kq->kq_count++; Regards Sylvain