From owner-freebsd-current@FreeBSD.ORG Thu May 27 01:57:22 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04CEE106564A for ; Thu, 27 May 2010 01:57:22 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.221.181]) by mx1.freebsd.org (Postfix) with ESMTP id AF7438FC0A for ; Thu, 27 May 2010 01:57:21 +0000 (UTC) Received: by qyk11 with SMTP id 11so10592362qyk.13 for ; Wed, 26 May 2010 18:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=TZ1syBdi5942HR1LR9wJSMw4Y5qYNp02Dowiq9jHqr4=; b=oq+Fs3i56T2shC+IaFWcCsOIUCotlk8QpdUstus8mBGawm0l9zFUYDrWqcfeRwIpL4 /gA/3K8D96XtN69FCzMzA1oeYcJ4/uucpJgP62NVq1sG8Uix7CSpuN8T4DtPgDv926my wat/aPfJ5tuUyvJRpLNJH9vwTD2qFfxj5EqMI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=mn3QRSdnQ5x3Q7AFEYM2Ks/WdEK0LLsT/PwE3i7CL/n4X48qh6BdJo68U6FbQx8pCd k8a2pl6KJ8+boWrcjrdPJAR0gOaHcvREhA7sQCDrIlmxXaqwWr/dCSFG/xrP0t7uDG3t Zadp/Yf0EYlefG9H303ulSjjQFG6Habt4FDA4= MIME-Version: 1.0 Received: by 10.229.95.137 with SMTP id d9mr2089125qcn.125.1274925440993; Wed, 26 May 2010 18:57:20 -0700 (PDT) Received: by 10.229.190.83 with HTTP; Wed, 26 May 2010 18:57:20 -0700 (PDT) In-Reply-To: <201005262159.27350.lobo@bsd.com.br> References: <201005262159.27350.lobo@bsd.com.br> Date: Wed, 26 May 2010 18:57:20 -0700 Message-ID: From: Garrett Cooper To: Mario Lobo Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current Subject: Re: SUJ Changes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2010 01:57:22 -0000 On Wed, May 26, 2010 at 2:59 PM, Mario Lobo wrote: > On Wednesday 26 May 2010 23:56:24 Garrett Cooper wrote: >> On Wed, May 26, 2010 at 3:52 PM, Marcelo/Porks > wrote: >> > On 5/25/10, Marcelo/Porks wrote: >> >> Hi! I tested the r208241 and it's seems to be ok but this calls my >> >> atention to other thing: Could I disable de SU when the SUJ is >> >> enabled? >> >> >> >> I did some tests and seems that I can do this (logs bellow). >> >> >> >> But will SUJ work properly with SU disabled? >> > >> > Hi guys. I'm not sure if I could call this a problem but I can disable >> > SU when SUJ is enabled, so SUJ will remain enabled and SU will be >> > disabled. >> > >> > #tunefs -j enable /dev/device >> > #tunefs -n disable /dev/device >> > >> > I did a patch for sbin/tunefs/tunefs.c that disable SUJ when the user >> > disable SU. Maybe this will be useful for some of you. >> > >> > Thanks. >> > >> > >> > Index: sbin/tunefs/tunefs.c >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > --- sbin/tunefs/tunefs.c =A0 =A0 =A0 =A0(revision 208580) >> > +++ sbin/tunefs/tunefs.c =A0 =A0 =A0 =A0(working copy) >> > @@ -460,6 +460,14 @@ >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if ((~sblock.fs_flags &= FS_DOSOFTDEP) =3D=3D >> > FS_DOSOFTDEP) warnx("%s remains unchanged as disabled", name); else { >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* also = disable SUJ */ >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if ((sbl= ock.fs_flags & FS_SUJ) =3D=3D FS_SUJ) >> > { + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 warnx("soft updates journaling >> > will be disabled too"); >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 journal_clear(); >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 sblock.fs_flags &=3D ~FS_SUJ; >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 sblock.fs_sujfree =3D 0; >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 warnx("remove .sujournal to >> > reclaim space"); >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sblock.= fs_flags &=3D ~FS_DOSOFTDEP; >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0warnx("= %s cleared", name); >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} >> >> I think that it makes sense to have this as a force option as someone >> may want to retain their journal instead of disposing of it >> automatically. >> >> I think that the 2nd warnx should be the first warnx, and the 2nd >> warnx can be removed as it'll be quickly followed up by >> cleared. Changing `remove' to `removing' and changing `.sujournal' to >> journal would a) make the action more correct and b) make the concept >> more straightforward as to what's being removed, as Jeff or someone >> else may decide to remove or rename .sujournal in the future, and it's >> just another thing that users don't have to understand that aren't >> familiar with FreeBSD or SUJ. >> > Is this available in 8-STABLE? Nope. > Can it be? Not sure (fs@ folks should make the call), but definitely not before 8.= 1. > Can this be activated on my current installation without loosing data? I suggest looking for SUJ in the current archives in the past 2 months. There are a number of threads that discuss how SUJ should be enabled. HTH, -Garrett