From owner-svn-src-all@freebsd.org Fri Apr 19 18:29:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C3D6C1575033; Fri, 19 Apr 2019 18:29:25 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-xc44.google.com (mail-yw1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 544A08BBDE; Fri, 19 Apr 2019 18:29:25 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-yw1-xc44.google.com with SMTP id e76so2155849ywa.9; Fri, 19 Apr 2019 11:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jp/VuxaLW34EsE/Yf4J6pEZU7qLK4ot8gNmmzGE8XkI=; b=BKvu7bdIwbtl0HfRKdSZZOVzS3znqQLqsJZfTS6+HJD7kfZk1AhE4y/WHgfxQKCotO gHov4vq3oJRvwQdkeHXVX23DPvIOYHlmPqT68fYAir6MtsreM1I+b5HanEe9JNlVkGwO YmpOWcDmXZr1SWEcEbbu4qHa2wnjmgXRlTpbmPcnFOFvhxkQ/P3e9x53SGJ9Pjlu5hHF ujjrPfDS5qy5gvd6h/NyOMlX7HuAvCEg0p74M/5WYTNfx8iKnkqNNCV5DYVBT93z/1QC dxD04/VUgcEqoopjqKv02pXkBXruwZ+1qjXZ0Px3xUZmT1nxWHJoHjGkC6lY4w/Y53ys 257Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=jp/VuxaLW34EsE/Yf4J6pEZU7qLK4ot8gNmmzGE8XkI=; b=G7B+Mg4aSj8+iQPlnivXBRNUMSO/buEWN3mTNLHdcciTvQb+OmhmFhKPNu+Wy+21+G l79DeQplKIc6BdMFxuhrojNx165JIR4fjfCxZXsnvr8Pl9uWSCTJW4GbA0tYad84Dicb V58foL4xf+inwBx9unRrWcpNYGchnYti8S9U/W6XxrsXaU5TnajhnBETGFbhPkCwekOt r3Ragjt8LLsvzDi8ur0Lbs0nZyPIFNi5SfFXuyx1lOE40piBQMWMIP1nj7q2yLrZmZqL mgqVGkIktE23oyyI7/cuQnRMYGukO5kJQRzdVIUBYjlVvottPnKEGK55hPNs0zuf8nvd sDfw== X-Gm-Message-State: APjAAAXvJASEPMlZVgUomCdcLfF+BUIb9wjq8TltmACqbxz/zrEkIiCa v6UElsjb9LFkgkqZoU6qUq8G2acQ X-Google-Smtp-Source: APXvYqwieeEh78VhFzYGn3NjkoCuGZcf620dW8DqqeSrbu8szDgBt9qrErBWSl1C5gGBKYar2X6lZg== X-Received: by 2002:a81:4c07:: with SMTP id z7mr4379331ywa.0.1555698564553; Fri, 19 Apr 2019 11:29:24 -0700 (PDT) Received: from mavoffice.ixsystems.com ([12.189.233.129]) by smtp.gmail.com with ESMTPSA id z193sm2001932ywa.70.2019.04.19.11.29.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 11:29:24 -0700 (PDT) Sender: Alexander Motin Subject: Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Enji Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201904191544.x3JFijLe075969@repo.freebsd.org> <0F708A9C-D29D-466A-B541-06DB7127349E@gmail.com> From: Alexander Motin Openpgp: preference=signencrypt Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAHNIUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPsLAlwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raTOwE0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAcLAZQQYAQoADwUCU7PEDAIbDAUJBaOagAAKCRCDGMOVW6sif7FRB/4k9y/GaGqU fcJiXdQHRAKHCUvbKMFgeEDHOg33qx+POS2Ah85/PXVa2jYBldCZDmYc+zl48aEMd163a7s3 0gJaB7CYElwxlKUk6c+5gwoYIJuJJzSzW0JzSD5ch7RIRxbfxrKdsiHrUW8AeduZWzlK6VaW RmWILgLmxfLdhEVFWxbr99GSeVFZaZwn6tl/8CvBcgYoARvJvl0V5zS1akQfEISYkwL9EfUI W44EOHranL5qUXkedXBYp6fRsooGrIimfwYxaC8FbXhk3FMgMjDMRiVq4POHo1iGeYETsUrL NM6184E25gPVtX2fb3RhM8Xh6BkwCZ6ZYbQ+AcD4F/cKwsB8BBgBCgAmAhsMFiEE6YzzxOac w80OV51VgxjDlVurIn8FAllgwtgFCQ0xzMwACgkQgxjDlVurIn9OqAf9FAcKWS95wTTbraXA qg/+bQyHgjlMtGCgkmfxLsbUGeqiFgmSIuoDrF7q6sYPs6p00CXXZRuuNZt0lX7O95re8mgz gxm5iJisZpdbHMVepYlw/AxT2wCHwxGCEe64Lm+A9vjlOd+3D3/6fSLwZ9WFCE6p6lQZ1CDg 09xe+JKSgC+KDqmn0tzGKyfSCuhRAq3XkZyxL1hxBaDeP0eeKlzoy7jXodf3wVvXXc0cmpza B5McuRHK4EU6jIioHo30YqPM4AjPHGxV2X1N6/Aayungzj9EXNZtKCxs6dsTvjniWa5VkZ9F 4SOdSbxEen1DZRYpeWnd7GVmO86n+5USkKCXPg== Message-ID: <8d763a63-0915-d9f6-1b90-5e902f06ebe4@FreeBSD.org> Date: Fri, 19 Apr 2019 14:29:23 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <0F708A9C-D29D-466A-B541-06DB7127349E@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 544A08BBDE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.936,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 18:29:26 -0000 On 19.04.2019 14:09, Enji Cooper wrote: >> On Apr 19, 2019, at 08:44, Alexander Motin wrote: >> >> Author: mav >> Date: Fri Apr 19 15:44:45 2019 >> New Revision: 346390 >> URL: https://svnweb.freebsd.org/changeset/base/346390 >> >> Log: >> Change the way FreeBSD GID inheritance is hacked. >> >> I believe previous ifdef caused NULL dereference in later zfs_log_create() >> on attempt to create file inside directory belonging to ephemeral group >> created on illumos, trying to write to log information about GID domain >> of the newly created file, inheriting the ephemeral GID. >> >> This patch reuses original illumos SGID code with exception that due to >> lack of ID mapping code on FreeBSD ephemeral GID will turn into GID_NOBODY >> by another ifdef inside zfs_fuid_map_id(). > > Hi mav@! > I was wondering, does this break ACL mappings with sticky bits for the group ID (or was it broken to begin with)? If the latter, does it make sense to file a bug/add a TODO comment? I don't believe this change should have any visible results for native FreeBSD pools. It does change change handling of some pools coming from illumos, but previous behavior in that case resulted in kernel panic, so anything else is better, while full compatibility is impossible, since FreeBSD has no kernel-side AD UID/GID mapping, used by illumos SMB. Could you better describe what ACL mapping breakage you are talking about? -- Alexander Motin