From owner-svn-ports-all@freebsd.org Fri Sep 21 19:41:32 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0AC2110A2494; Fri, 21 Sep 2018 19:41:32 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B89D38D757; Fri, 21 Sep 2018 19:41:31 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id B0E7CA39C; Fri, 21 Sep 2018 19:41:31 +0000 (UTC) From: Jan Beich To: Kurt Jaeger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r480301 - in head/graphics: ImageMagick ImageMagick7 References: <201809211837.w8LIbU1U018468@repo.freebsd.org> Date: Fri, 21 Sep 2018 21:41:27 +0200 In-Reply-To: <201809211837.w8LIbU1U018468@repo.freebsd.org> (Kurt Jaeger's message of "Fri, 21 Sep 2018 18:37:30 +0000 (UTC)") Message-ID: <4lei-wsd4-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 19:41:32 -0000 Kurt Jaeger writes: > Author: pi > Date: Fri Sep 21 18:37:30 2018 > New Revision: 480301 > URL: https://svnweb.freebsd.org/changeset/ports/480301 > > Log: > graphics/ImageMagick[7]: remove CONFLICTS with lang/execline > > - lang/execline dropped their bin/import, so it no longer conflicts > > PR: 185818 > Submitted by: mj@netauth.com > Approved by: koobs (maintainer timeout) Did you mean kwm, not koobs? I'm pretty sure the important bit during timeout is how much time elapsed rather than who the maintainer is. > Modified: head/graphics/ImageMagick7/Makefile > ============================================================================== > --- head/graphics/ImageMagick7/Makefile Fri Sep 21 18:20:32 2018 (r480300) > +++ head/graphics/ImageMagick7/Makefile Fri Sep 21 18:37:30 2018 (r480301) > @@ -1,7 +1,7 @@ > # $FreeBSD$ > > PORTNAME= ImageMagick > -DISTVERSION= 7.0.7-16 > +DISTVERSION= 7.0.8-10 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230788 has been submitted just a day ago. Not enough for maintainer timeout. Maybe back the commit out and reland properly. It's unlikely to build at all because distinfo wasn't updated. > PORTREVISION= 1 Kinda late but PORTREVISION bump should have been reset. > CATEGORIES= graphics perl5 > MASTER_SITES= http://www.imagemagick.org/download/ \ > @@ -61,7 +60,7 @@ PLIST_SUB= PORTVERSION=${PORTVERSION:R} > OPTIONS_DEFINE= BZIP2 DOCS DJVU FFTW FONTCONFIG FPX FREETYPE \ > GRAPHVIZ GSLIB JPEG2000 JBIG JPEG LCMS2 LZMA LQR MODULES \ > OPENEXR OPENMP PANGO PDF PERL PNG SVG TESTS TIFF WEBP WMF \ > - THREADS X11 16BIT_PIXEL HDRI > + THREADS X11 16BIT_PIXEL HDRI HEIF > OPTIONS_DEFAULT= 16BIT_PIXEL BZIP2 FFTW FONTCONFIG FREETYPE \ > JPEG2000 JBIG JPEG LCMS2 LZMA LQR MODULES PDF PERL PNG SVG \ > TIFF WEBP WMF THREADS X11 HDRI > @@ -362,6 +361,18 @@ USES+= ghostscript:x11 > . else > USES+= ghostscript > . endif > +.endif > + > +## HEIF (High EfficiencImage Format) support > +HEIF_DESC= High Efficiency Image File support (e.g. from iPhone) Why are you breaking existing style by adding _DESC in the middle of conditionals? > + > +.if ${PORT_OPTIONS:MHEIF} > +LIB_DEPENDS+= libheif.so:graphics/libheif > +CONFIGURE_ARGS+= --with-heic > +PLIST_SUB+= HEIF="" > +.else > +CONFIGURE_ARGS+= --without-heic > +PLIST_SUB+= HEIF="@comment " > .endif Why do you need PLIST_SUB without lines in pkg-plist?