From owner-freebsd-smp Wed Dec 4 08:56:31 1996 Return-Path: owner-smp Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA29734 for smp-outgoing; Wed, 4 Dec 1996 08:56:31 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id IAA29723 for ; Wed, 4 Dec 1996 08:56:26 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.4/8.8.4) with ESMTP id AAA00583; Thu, 5 Dec 1996 00:56:05 +0800 (WST) Message-Id: <199612041656.AAA00583@spinner.DIALix.COM> To: Erich Boleyn cc: smp@freebsd.org Subject: Re: Greater than 2 CPUs... problem with my diff In-reply-to: Your message of "Wed, 04 Dec 1996 08:51:15 PST." Date: Thu, 05 Dec 1996 00:56:05 +0800 From: Peter Wemm Sender: owner-smp@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Erich Boleyn wrote: > > I just realized the diff I just sent was conceptually wrong (though it > would probably work for all existing machines, and worked fine for mine). > The real diff I should have sent for mp_machdep.c is included here, so > please use that instead! > > -----------------(start cvs diff sys/i386/i386/mp_machdep.c)----------------- > Index: sys/i386/i386/mp_machdep.c > =================================================================== > RCS file: /usr/cvssup/sys/i386/i386/mp_machdep.c,v > retrieving revision 1.28 > diff -r1.28 mp_machdep.c > 778c778,779 > < /* add another AP to list */ > --- > > /* add another AP to list, if less than max number of CPUs */ > > if ( x == (NCPU-1) ) return; > 780,783d780 > < if ( x == NCPU ) { > < printf( "too many CPUs, increase 'NCPU'\n" ); > < panic( "\n" ); > < } > ------------------(end cvs diff sys/i386/i386/mp_machdep.c)------------------ Umm, where is 'x' initialised? it's very hard to see exactly what you're trying to do, a context diff would be a lot better... Cheers, -Peter