Date: Thu, 15 Sep 2016 21:23:13 +0200 From: "Carlos J. Puga Medina" <cpm@FreeBSD.org> To: Olivier Duchateau <olivierd@freebsd.org>, amdmi3 <amdmi3@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r422218 - head/net-im/corebird Message-ID: <1473967393.1449.5.camel@FreeBSD.org> In-Reply-To: <20160915205647.6e85ca84807f4b6880171f70@freebsd.org> References: <201609151756.u8FHuvAS093292@repo.freebsd.org> <20160915205647.6e85ca84807f4b6880171f70@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-+X6sNwTfzXEsrjhscvzS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-09-15 at 20:56 +0200, Olivier Duchateau wrote: > On Thu, 15 Sep 2016 17:56:57 +0000 (UTC) > "Carlos J. Puga Medina" <cpm@FreeBSD.org> wrote: >=20 > >=20 > > Author: cpm > > Date: Thu Sep 15 17:56:56 2016 > > New Revision: 422218 > > URL: https://svnweb.freebsd.org/changeset/ports/422218 > >=20 > > Log: > > =C2=A0 - Update corebird to 1.3.1 release > > =C2=A0 - Add GSTREAMER_USE=3Dhls dependency > > =C2=A0 - Line up options block > > =C2=A0 - Silence all three explicitly called commands > Why hide these commands? >=20 > Your mentor (here, Dmitry) argues for the opposite (see his recent > changes with revision r421635, I know it's for CMake, Ninja, > autotools and so on) and he approves this. >=20 > I don't understand his behaviour. >=20 I'm not completely sure, but hide such commands would be rather consider as a cosmetic fix. If Dmitry sees this comment, he may shed some light here :) > >=20 > > =C2=A0=C2=A0 > > =C2=A0 Changelog: > > =C2=A0=C2=A0=C2=A0=C2=A0https://github.com/baedert/corebird/releases/ta= g/1.3.1 > > =C2=A0=C2=A0 > > =C2=A0 Reviewed by: amdmi3 (mentor) > > =C2=A0 Approved by: amdmi3 (mentor) > > =C2=A0 Differential Revision: D7800 > >=20 > > Modified: > > =C2=A0 head/net-im/corebird/Makefile > > =C2=A0 head/net-im/corebird/distinfo > >=20 > > Modified: head/net-im/corebird/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- head/net-im/corebird/Makefile Thu Sep 15 17:30:23 2016=09 > > (r422217) > > +++ head/net-im/corebird/Makefile Thu Sep 15 17:56:56 2016=09 > > (r422218) > > @@ -2,7 +2,7 @@ > > =C2=A0# $FreeBSD$ > > =C2=A0 > > =C2=A0PORTNAME=3D corebird > > -PORTVERSION=3D 1.3 > > +PORTVERSION=3D 1.3.1 > > =C2=A0CATEGORIES=3D net-im > > =C2=A0 > > =C2=A0MAINTAINER=3D cpm@FreeBSD.org > > @@ -26,23 +26,23 @@ GNU_CONFIGURE=3D yes > > =C2=A0USE_GNOME=3D atk cairo gdkpixbuf2 glib20 gtk30 intltool > > libxml2 pango > > =C2=A0INSTALLS_ICONS=3D yes > > =C2=A0 > > -OPTIONS_DEFINE=3D GSTREAMER > > -OPTIONS_DEFAULT=3D GSTREAMER > > -GSTREAMER_USE=3D gstreamer1=3Dyes,bad,good,gtksink,libav,x,xima > > gesrc > > +OPTIONS_DEFINE=3D GSTREAMER > > +OPTIONS_DEFAULT=3D GSTREAMER > > +GSTREAMER_USE=3D gstreamer1=3Dyes,bad,good,gtks > > ink,hls,libav,x,ximagesrc > > =C2=A0GSTREAMER_CONFIGURE_OFF=3D --disable-video > > =C2=A0 > > =C2=A0GLIB_SCHEMAS=3D org.baedert.corebird.gschema.xml > > =C2=A0 > > =C2=A0post-extract: > > - cd ${WRKSRC}/data && ${MV} org.baedert.corebird.desktop.in > > \ > > - corebird.desktop.in > > + @(cd ${WRKSRC}/data && ${MV} > > org.baedert.corebird.desktop.in \ > > + corebird.desktop.in) > > =C2=A0 > > =C2=A0pre-configure: > > - ${MKDIR} ${WRKSRC}/m4 > > + @${MKDIR} ${WRKSRC}/m4 > > =C2=A0 > > =C2=A0# Replace locales files in right place > > =C2=A0post-configure: > > - ${REINPLACE_CMD} -e 's|[$$][(]DATADIRNAME[)]|share|' \ > > + @${REINPLACE_CMD} -e 's|[$$][(]DATADIRNAME[)]|share|' \ > > =C2=A0 ${WRKSRC}/po/Makefile > > =C2=A0 > > =C2=A0.include <bsd.port.mk> > >=20 > > Modified: head/net-im/corebird/distinfo > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- head/net-im/corebird/distinfo Thu Sep 15 17:30:23 2016=09 > > (r422217) > > +++ head/net-im/corebird/distinfo Thu Sep 15 17:56:56 2016=09 > > (r422218) > > @@ -1,3 +1,3 @@ > > -TIMESTAMP =3D 1470087209 > > -SHA256 (baedert-corebird-1.3_GH0.tar.gz) =3D > > f4f86a2e898342297c2379c25b6274598d81d8983f185d98753725552f670860 > > -SIZE (baedert-corebird-1.3_GH0.tar.gz) =3D 431652 > > +TIMESTAMP =3D 1473189673 > > +SHA256 (baedert-corebird-1.3.1_GH0.tar.gz) =3D > > cbc832b9e3adab698b9b879b64e33bffd708776e08fe9f229885068193525190 > > +SIZE (baedert-corebird-1.3.1_GH0.tar.gz) =3D 433961 > >=20 >=20 --=20 Carlos Jacobo Puga Medina <cpm@FreeBSD.org> PGP fingerprint =3D C60E 9497 5302 793B CC2D BB89 A1F3 5D66 E6D0 5453 --=-+X6sNwTfzXEsrjhscvzS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJX2vUiXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNjBFOTQ5NzUzMDI3OTNCQ0MyREJCODlB MUYzNUQ2NkU2RDA1NDUzAAoJEKHzXWbm0FRTvpAH/2kwwA6mbKtxYe/GNCJu/8ym 2SGvxjuEMdj1RwxRP5GEwIxyChTguTop+emU8RC4gpDEPqtRHi9v+gc3+iXhd8iQ PY5ZqJBeR83FTgb9L/+6LKq/BCRzX31S0189FFbaS5u4yvTmeb2wytyjQxf9uCAe JT6PQjkVxwf5g2K0NxptARvziZRN4rqWEggl43OT1ZKv/5X8xdRzxgNgaNfGxh9s j9o/WoSNb3dELDe1KH2B+J+TFqXWZ152tFKzzUOOp5bY7WxJF4spVdrS3Nmo3+mo w6Qevnjh6hTx7ebwj2g7hSKMzE+v/WN3tFzlvw9M8Dq/Lw18DV8Lp+CauZIgL9U= =g8/G -----END PGP SIGNATURE----- --=-+X6sNwTfzXEsrjhscvzS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1473967393.1449.5.camel>