From owner-freebsd-ports Tue Mar 28 15:30:16 2000 Delivered-To: freebsd-ports@freebsd.org Received: from viper.lovett.com (hub.lovett.com [216.60.121.161]) by hub.freebsd.org (Postfix) with ESMTP id 6F66837C080 for ; Tue, 28 Mar 2000 15:30:09 -0800 (PST) (envelope-from ade@lovett.com) Received: from ade by viper.lovett.com with local (Exim 3.13 #1) id 12a5R0-000CMu-00; Tue, 28 Mar 2000 17:30:06 -0600 Date: Tue, 28 Mar 2000 17:30:06 -0600 From: Ade Lovett To: Mikhail Teterin Cc: freebsd-ports@FreeBSD.org Subject: Re: ports/12739: New port: AT&T's DjVu Netscape plug-in Message-ID: <20000328173006.N69223@lovett.com> References: <20000328170640.M69223@lovett.com> <200003282321.SAA04202@xxx.video-collage.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: <200003282321.SAA04202@xxx.video-collage.com>; from mi@video-collage.com on Tue, Mar 28, 2000 at 06:21:06PM -0500 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Tue, Mar 28, 2000 at 06:21:06PM -0500, mi@video-collage.com wrote: > > Well, if I harcode MOZILLA_HOME as ${LOCALBASE}/lib/netscape, there is > no problem. But I did not want to do that... Hmm.. there's also: viper 415# make fetch >> npdjvu-freebsd.tar.gz doesn't seem to exist on this system. >> Attempting to fetch from http://www.djvu.att.com/download/plugin/. fetch: npdjvu-freebsd.tar.gz: www.djvu.att.com: HTTP server returned error code 404 I believe I already mentioned that the site was moved to www.djvu.com > = I'd strongly recommend installing devel/portlint and using it to clean > = things up before submission. > > I used it: Looks like you missed some flags.. as a rule, I tend to use: portlint -abcNv which gives a better idea of any issues. > I put the "TAR?=tar" and "LN?=ln" in there on purpose, because I tested > this port on an old 2.2.8 machine with old bsd.port.mk. The two other > warnings are bogus too -- one is there because of quotes around > ${MOZILLA_HOME} (what if it has spaces in it?) and the other is because > RUN_DEPENDS lists ${MOZILLA_HOME}. My (possibly incorrect) understanding is that support for both 2.x and aout 3.x has ceased. > I'm sure I'm not. With the NO_CDROM/NO_PACKAGE we are not even a party > of the license agreement... This way the port is not interactive, which > is good, is not it?... My understanding of the license agreement is that it needs to be presented to, and accepted by, the end user, before proceeding. Usual disclaimers about not being a lawyer apply, but the fact that you have a bunch of comments in there suggest that you thought about this enough to put them in. If it's not a problem, why have the comments at all, since most people won't be reading the Makefile anyway. -aDe -- Ade Lovett, Austin, TX. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message