From owner-svn-src-head@freebsd.org  Sun Mar 12 02:44:59 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C69ACD07D22;
 Sun, 12 Mar 2017 02:44:59 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au
 [211.29.132.97])
 by mx1.freebsd.org (Postfix) with ESMTP id 90A371561;
 Sun, 12 Mar 2017 02:44:58 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from besplex.bde.org (c122-106-153-191.carlnfd1.nsw.optusnet.com.au
 [122.106.153.191])
 by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 5A209102F2F;
 Sun, 12 Mar 2017 13:44:51 +1100 (AEDT)
Date: Sun, 12 Mar 2017 13:44:50 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Andriy Gapon <avg@freebsd.org>
cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Subject: Re: svn commit: r315068 - head/sys/modules/qlxgbe
In-Reply-To: <201703111516.v2BFGtkn006959@repo.freebsd.org>
Message-ID: <20170312124945.C4483@besplex.bde.org>
References: <201703111516.v2BFGtkn006959@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.2 cv=AYLBJzfG c=1 sm=1 tr=0
 a=Tj3pCpwHnMupdyZSltBt7Q==:117 a=Tj3pCpwHnMupdyZSltBt7Q==:17
 a=kj9zAlcOel0A:10 a=TpLjFTHyFfqqnH7asFwA:9 a=CjuIK1q_8ugA:10
 a=HzLR6qCuIIUA:10
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Mar 2017 02:44:59 -0000

On Sat, 11 Mar 2017, Andriy Gapon wrote:

> Log:
>  revert r314862, use of GCC_MS_EXTENSIONS in qlxgbe
>
>  Commit r278913 made explicit use of GCC_MS_EXTENSIONS  unnecessary.
>
>  Requested by:	glebius

Does this module actually use ms extensions?  This seems unlikely, since
only gcc supports them.

My kernels compile correctly with the correct CFLAGS (gcc -std=gnu99
-fno-ms-extensions).

Bruce