From owner-freebsd-arch@FreeBSD.ORG Thu Mar 25 11:55:08 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 416E71065677; Thu, 25 Mar 2010 11:55:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 11A598FC26; Thu, 25 Mar 2010 11:55:08 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 8ED4546B98; Thu, 25 Mar 2010 07:55:07 -0400 (EDT) Received: from jhbbsd.localnet (localhost [IPv6:::1]) by bigwig.baldwin.cx (Postfix) with ESMTPA id ACE058A021; Thu, 25 Mar 2010 07:55:06 -0400 (EDT) From: John Baldwin To: Alexander Leidinger Date: Thu, 25 Mar 2010 07:49:57 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <20100322.125937.278730673160410010.imp@bsdimp.com> <201003241132.29588.jhb@freebsd.org> <20100325105615.10186jr08a5oj00s@webmail.leidinger.net> In-Reply-To: <20100325105615.10186jr08a5oj00s@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003250749.57994.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 25 Mar 2010 07:55:06 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.1 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2010 11:55:08 -0000 On Thursday 25 March 2010 5:56:15 am Alexander Leidinger wrote: > Quoting John Baldwin (from Wed, 24 Mar 2010 11:32:29 -0400): > > > On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote: > >> Quoting John Baldwin (from Wed, 24 Mar 2010 10:05:55 > > -0400): > >> > >> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote: > >> > >> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk > >> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means > >> >> that all makeoptions do not propagate to module builds. > >> >> > >> >> Any ideas? > >> > > >> > Hmmmm. That's odd because 'DEBUG=-g' does work. Ah, I think you should > >> > patch kern.post.mk to propogate WITH_CTF to modules. This is how it works > >> > for DEBUG now: > >> > > >> > .if defined(DEBUG) > >> > MKMODULESENV+= DEBUG_FLAGS="${DEBUG}" > >> > .endif > >> > >> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk > >> instead of kernl.post.mk)? > > > > No, I think it is fine to treat it the same as DEBUG. > > DEBUG is in kern.pre.mk, and thus can be overriden. Currently I have > WITH_CTF handling in kern.post.mk, and thus it can not be overriden. > There are some MKMODULESENV things in post.mk already. Ok. > On a related note, the LD_CTF_FLAGS thing does not seem to work for > modules. Reading the man page of ld tells that -g is a noop (the > switch is ignored). Thus I would prefer to remove the setting of -g > for ld. Any objections? Ok. -- John Baldwin