Date: Wed, 14 Aug 2019 15:20:33 -0600 From: Adam Weinberger <adamw@adamw.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: Adriaan de Groot <adridg@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r508922 - in head: databases/opendbviewer devel/cmake devel/cmake-doc devel/cmake-gui devel/cmake/files devel/kms-cmake-utils graphics/peruse/files misc/libemos misc/libemos/files Message-ID: <CAP7rwci8nmjwm9AKdtUdHWDRG0atLoj5c50GcexdbFNCV7ujPw@mail.gmail.com> In-Reply-To: <CAMHz58QkXgvPc-eoi_-2zaK7ZWHZahGAtdYprTJP4yZbD=H7cQ@mail.gmail.com> References: <201908141418.x7EEIbcB050123@repo.freebsd.org> <CAMHz58QkXgvPc-eoi_-2zaK7ZWHZahGAtdYprTJP4yZbD=H7cQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 14, 2019 at 11:33 AM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > > On Wed, Aug 14, 2019 at 10:18 PM Adriaan de Groot <adridg@freebsd.org> wrote: >> >> Author: adridg >> Date: Wed Aug 14 14:18:36 2019 >> New Revision: 508922 >> URL: https://svnweb.freebsd.org/changeset/ports/508922 >> >> Log: >> Update devel/cmake to 3.15.2 (latest upstream release) >> >> Release notes for the version updates are at: >> https://blog.kitware.com/cmake-3-15-0-available-for-download/ >> https://blog.kitware.com/cmake-3-15-1-available-for-download/ >> https://blog.kitware.com/cmake-3-15-2-available-for-download/ >> >> For FreeBSD, not much interesting has changed. Swift language support >> might be useful. >> >> A few ports were fixed as part of this exp-run (libemos not really >> related to the CMake update, but in general). Thanks to antoine >> for the exp-runs, tcberner for doing most of the prep-work. >> >> PR: 239273 >> Submitted by: tcberner >> >> Added: >> head/graphics/peruse/files/ >> head/graphics/peruse/files/patch-src_qtquick_karchive_rar_CMakeLists.txt (contents, props changed) >> head/misc/libemos/files/patch-libemos-dp_CMakeLists.txt (contents, props changed) >> head/misc/libemos/files/patch-libemos-sp_CMakeLists.txt (contents, props changed) >> Modified: >> head/databases/opendbviewer/Makefile >> head/devel/cmake-doc/Makefile >> head/devel/cmake-gui/Makefile >> head/devel/cmake/Makefile >> head/devel/cmake/distinfo >> head/devel/cmake/files/patch-Source_CPack_cmCPackFreeBSDGenerator.cxx >> head/devel/cmake/pkg-plist >> head/devel/kms-cmake-utils/pkg-plist >> head/misc/libemos/pkg-plist >> >> Modified: head/devel/cmake/pkg-plist >> ============================================================================== >> --- head/devel/cmake/pkg-plist Wed Aug 14 13:50:28 2019 (r508921) >> +++ head/devel/cmake/pkg-plist Wed Aug 14 14:18:36 2019 (r508922) >> [...] >> @@ -1032,11 +1059,12 @@ share/aclocal/cmake.m4 >> %%DATADIR%%/Help/release/3.12.rst >> %%DATADIR%%/Help/release/3.13.rst >> %%DATADIR%%/Help/release/3.14.rst >> +%%DATADIR%%/Help/release/3.15.rst >> %%DATADIR%%/Help/release/3.2.rst >> %%DATADIR%%/Help/release/3.3.rst >> %%DATADIR%%/Help/release/3.4.rst >> %%DATADIR%%/Help/release/3.5.rst >> -%%DATADIR%%/Help/release/3.6.rst >> +%%DATADIR%%/Help/release/%%PYTHON_VER%%.rst > > > Hi, > > This change is incorrect. > And it breaks packaging for people not using Python 3.6 as default version. > > For example, users with DEFAULT_VERSIONS=python=3.7 in /etc/make.conf would encounter: > ===> Building package for cmake-3.15.2 > pkg-static: Unable to access file /usr/ports/devel/cmake/work/stage/usr/local/share/cmake/Help/release/%%PYTHON_VER%%.rst:No such file or directory > *** Error code 1 > > Stop. > make: stopped in /usr/ports/devel/cmake Thanks, Po-Chuan. This looks like the kind of mistake that using makeplist without reviewing the results can cause. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwci8nmjwm9AKdtUdHWDRG0atLoj5c50GcexdbFNCV7ujPw>