From owner-svn-src-all@freebsd.org Thu Feb 22 16:21:09 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02CA1F136D6; Thu, 22 Feb 2018 16:21:09 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B0A46B70E; Thu, 22 Feb 2018 16:21:08 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-lf0-f45.google.com with SMTP id 37so8190031lfs.7; Thu, 22 Feb 2018 08:21:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=T9sV2CKIRMVFL5NVuvAoS/g4ZhimKRHgwX8oKDOIZ7k=; b=eOyS590oh6x93XTN+bqTN+GVWBE3V3+NxUQ/YkjLPGJ0zWKL1QnG7MdRxVDT2eSZMO VtZ665YWVMnTV6kqj+B0aCJ1gMqxBA6hlYDPwpCS3X5o5pVlbKhVJNFthAORmytXv7IH UAQw5CivW/o55/jexdjpXjButnKvcphr5jGpkUUct+jtktOImTca7jjmLc3eAmsn8NOJ V8XtJ9YWx4+IgSqKKXnolAnHRzFqLWO5lXjYSVo9GIH+2WzrOB7LD1hxr1HgL6pMRxpQ eNRmEEPCq58s42alBhqJ/BTEY8DPB26bsT8ry8BsTKox1PMJpbaZ4CbtGFkmmPWOmWUs D7YA== X-Gm-Message-State: APf1xPCqVBw8V1qNT6wQNUz8nTR/RXsgUXbZqfajLvUj9EE1FvNxlYEj cm2JDGd/zZ6APpzi/fiy1b9u2nvxmIQ= X-Google-Smtp-Source: AH8x225zg/LzL4F2isQGDP/VfLtpi0QEmfgeGdUQqi63Bp46DPcEd0QDWMf9x11ZMcfuOIyDivIqwQ== X-Received: by 10.46.41.157 with SMTP id p29mr5078854ljp.137.1519316461229; Thu, 22 Feb 2018 08:21:01 -0800 (PST) Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com. [209.85.215.54]) by smtp.gmail.com with ESMTPSA id 5sm82704ljv.29.2018.02.22.08.21.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Feb 2018 08:21:01 -0800 (PST) Received: by mail-lf0-f54.google.com with SMTP id m69so8192627lfe.8; Thu, 22 Feb 2018 08:21:01 -0800 (PST) X-Received: by 10.46.114.26 with SMTP id n26mr4374200ljc.74.1519316460670; Thu, 22 Feb 2018 08:21:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.46.54.1 with HTTP; Thu, 22 Feb 2018 08:20:40 -0800 (PST) In-Reply-To: References: <201802221332.w1MDWVao004564@repo.freebsd.org> From: Kyle Evans Date: Thu, 22 Feb 2018 10:20:40 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme To: Alan Somers Cc: Wojciech Macek , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 16:21:09 -0000 On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > >> Author: wma >> Date: Thu Feb 22 13:32:31 2018 >> New Revision: 329824 >> URL: https://svnweb.freebsd.org/changeset/base/329824 >> >> Log: >> NVMe: Add big-endian support >> >> Remove bitfields from defined structures as they are not portable. >> Instead use shift and mask macros in the driver and nvmecontrol >> application. >> >> NVMe is now working on powerpc64 host. >> >> Submitted by: Michal Stanek >> Obtained from: Semihalf >> Reviewed by: imp, wma >> Sponsored by: IBM, QCM Technologies >> Differential revision: https://reviews.freebsd.org/D13916 >> > > It looks like this change broke the build with Clang: > Fixed in r329827... all little endian arch's broken, not so great. =(