From owner-svn-ports-all@FreeBSD.ORG Thu Nov 27 08:33:01 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A9A58D7F; Thu, 27 Nov 2014 08:33:01 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7DBE0E4C; Thu, 27 Nov 2014 08:33:00 +0000 (UTC) Received: from [10.31.9.177] (unknown [213.225.137.129]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id C2A3343552; Thu, 27 Nov 2014 02:32:48 -0600 (CST) Message-ID: <5476E1A5.1010307@marino.st> Date: Thu, 27 Nov 2014 09:32:37 +0100 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Tijl Coosemans Subject: Re: svn commit: r373458 - in head/www: linux-c6-flashplugin11 linux-f10-flashplugin11 References: <201411261948.sAQJmO9U029389@svn.freebsd.org> <20141126211459.241dfadb@kalimero.tijl.coosemans.org> <547635FD.5080407@marino.st> <20141127092101.3f977182@kalimero.tijl.coosemans.org> In-Reply-To: <20141127092101.3f977182@kalimero.tijl.coosemans.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, jbeich@vfemail.net, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 08:33:01 -0000 On 11/27/2014 09:21, Tijl Coosemans wrote: > On Wed, 26 Nov 2014 21:20:13 +0100 John Marino wrote: >> On 11/26/2014 21:14, Tijl Coosemans wrote: >>> On Wed, 26 Nov 2014 19:48:24 +0000 (UTC) John Marino wrote: >>>> +%%NO_ALSA%%%%LINUXBASE%%/usr/lib/libflashsupport.so >>>> +%%NO_ALSA%%@dir %%LINUXBASE%%/usr/lib >>>> +%%NO_ALSA%%@dir %%LINUXBASE%%/usr >>>> +%%NO_ALSA%%@dir %%LINUXBASE%% >>>> +%%NO_ALSA%%@dir %%COMPATDIR%% >>> >>> Traditionally /compat is a symlink to /usr/compat, so I'm not sure it's >>> safe to delete it like this. But even if it is this port depends on >>> emulators/linux_base so none of these @dir are necessary. >> >> The port was creating empty directories in stagedir when ALSA option is >> off. So at least in one case, they are necessary (or deleting from >> stagedir is necessary). Nothing is getting deleted. > > The directory %%LINUXBASE%%/usr/lib isn't empty. It contains > libflashsupport.so. And that directory belongs to emulators/linux_base > so this port does not have to list it with @dir. So at worst it's a no-op, right? pkg won't create a directory if it already exists - and won't delete if it's still contains files. make check-plist was coming back with *errors*. I don't want to accept errors as normal. No port should fail -t checks in poudriere. Do you know a better solution that doesn't result in make check-plist failure? Perhaps removing the directories from stagedir instead? John