From owner-cvs-all Mon Dec 31 12:39:45 2001 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id 2599937B430 for ; Mon, 31 Dec 2001 12:39:23 -0800 (PST) Received: (qmail 25359 invoked from network); 31 Dec 2001 20:39:22 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 31 Dec 2001 20:39:22 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200112310656.fBV6uVT21497@freefall.freebsd.org> Date: Mon, 31 Dec 2001 12:39:12 -0800 (PST) From: John Baldwin To: Ian Dowse Subject: RE: cvs commit: src/sys/nfs nfs_common.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 31-Dec-01 Ian Dowse wrote: > iedowse 2001/12/30 22:56:31 PST > > Modified files: > sys/nfs nfs_common.c > Log: > When the old nfsm_adv() macro was moved to nfsm_adv_xx(), a '>=' > must have been inadvertently changed to '>'. This broke nfsm_adv() > in the case where the advancement count is equal to the amount of > data remaining in the current mbuf. Instead of moving the current > position N bytes forward, nfs_adv() could end up moving it back to > N bytes from the start of the mbuf data. > > This should fix the client-side readdirplus problems that have been > reported since September. Wow! Nice catch. Those 1 character bugs always suck. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message