From nobody Sat Sep 27 14:36:22 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cYqlB3k8bz69PyK; Sat, 27 Sep 2025 14:36:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cYqlB1xCLz3xqk; Sat, 27 Sep 2025 14:36:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758983782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nRxKEpx0ZGs7WnrtToXlJYyYLqGf4QN+dyqGZMRdb7Q=; b=N3nes8dFz3jF1l1lWf9bhmEPBHMIGCJh1JAuZljZ9sHtFNx8gK0bErhVovmDCiKUfVISzV LqIAxGUknoeGcVMxmc7axWU2ZeWrC2fETjuPh+12u1kzDonFOrVNzDo3cbKkkp6Emiu770 es8hQFNYm1kPWtwIlv6OuTp4u5W0MKHQoOMqOslIJ2kNFC0dq/zspARG22lktUfeuuV3Eh i1TIVmQ4bNcaip5Ohkm7EEnQjy/m1wNj0cLh+OJILRffMhSoQ9URdvX8L6z3G1CGlJpdNW 4IqANMlrBaiXzSGVV6Oo4nGzMJJP0O+oUQ0jL52DtHctbByI9TqYGCIN/bW0WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758983782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nRxKEpx0ZGs7WnrtToXlJYyYLqGf4QN+dyqGZMRdb7Q=; b=b003jHE8YaMIN0cLwdYcTEzdC9POenJiEMQUQgVOcuzy9jB/i+7wB7gTLUil81BrXcTboI IrN7NGAu9ZMJjOgrOsI5ym6kFoRb5AxgGyiRbLWCIppurMs2TgPl3c9zcdx+9Demvb+5Kq bEFSdvN/wb87BmjHw3ZnKDso48rqQevz1omKg7K8jYde4FTlqpidLZpSSX4jPmKrB/6YTG PYXDYGSbYw+rRAAQzSUwhMUnQETbcWiyoAaRUGikUPXdXc50sq2OOHzecJBimeBguQ1OMy v1a7tlpqia73vnOnra/HPX5X2m8zdSfUd0nhptBBpmE0f4l2YaHqbqkkjiBcmg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758983782; a=rsa-sha256; cv=none; b=hlSsfCkwWpRDKPNsAnLMzvRBaL4M/6h42HFfkQZyn1S8g3ImbE83m6/WKVySnNen8qLKDH gSKeLFqF7un25AkODVbWar9WnZHmkCESpXFyfx/8aG2syn3esGkT8Ledmfc6IgAxje0hlA DxsyQzQsYG73YshwN+S3tKNE7FjhMQ37djl1Qi5vxenbxs/sPbWFSc88s6e2A4+7j2WieU bJs4eC1pM7RmSn06AehkqJeQbBoN/Y5TuqG3oDj9cX0fbBHer1F7okFRJeV2KEteKvqM0W t5AbexigCJdriZ+iiIXHgiIfvD3BhFM2RmYOcP1dxUjVZi2ZRzXc8Bwa7zouhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cYqlB1Qdpzf1w; Sat, 27 Sep 2025 14:36:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58REaMBA007383; Sat, 27 Sep 2025 14:36:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58REaMPt007380; Sat, 27 Sep 2025 14:36:22 GMT (envelope-from git) Date: Sat, 27 Sep 2025 14:36:22 GMT Message-Id: <202509271436.58REaMPt007380@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: 7dc691b70353 - stable/14 - fusefs: fix the last_local_modify LLM/LastLocalModify.lookup/3 test List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7dc691b703537113c686add53e2789566c8ab9e6 Auto-Submitted: auto-generated The branch stable/14 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=7dc691b703537113c686add53e2789566c8ab9e6 commit 7dc691b703537113c686add53e2789566c8ab9e6 Author: Alan Somers AuthorDate: 2025-09-15 00:22:36 +0000 Commit: Alan Somers CommitDate: 2025-09-27 14:29:52 +0000 fusefs: fix the last_local_modify LLM/LastLocalModify.lookup/3 test The LastLocalModify tests were originally written to simulate a race condition between VOP_SETATTR and VOP_LOOKUP. They were later extended to cover some other VOPs that can affect file size, including VOP_WRITE. However, the test never correctly simulated the race with VOP_WRITE. So that test only ever passed by accident. Fix it by always opening the file with O_DIRECT. PR: 289237 Reported by: Siva Mahadevan (cherry picked from commit d1eaa52d10f9b85e5f6358e1a280899b9d55dd07) --- tests/sys/fs/fusefs/last_local_modify.cc | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/sys/fs/fusefs/last_local_modify.cc b/tests/sys/fs/fusefs/last_local_modify.cc index 5fcd3c36c892..6b8c19f1efc7 100644 --- a/tests/sys/fs/fusefs/last_local_modify.cc +++ b/tests/sys/fs/fusefs/last_local_modify.cc @@ -174,7 +174,15 @@ static void* write_th(void* arg) { if (sem) sem_wait(sem); - fd = open("mountpoint/some_file.txt", O_RDWR); + /* + * Open the file in direct mode. + * The race condition affects both direct and non-direct writes, and + * they have separate code paths. However, in the non-direct case, the + * kernel updates last_local_modify _before_ sending FUSE_WRITE to the + * server. So the technique that this test program uses to invoke the + * race cannot work. Therefore, test with O_DIRECT only. + */ + fd = open("mountpoint/some_file.txt", O_RDWR | O_DIRECT); if (fd < 0) return (void*)(intptr_t)errno; @@ -332,7 +340,7 @@ TEST_P(LastLocalModify, lookup) /* Wait for FUSE_SETATTR to be sent */ sem_wait(&sem); - /* Lookup again, which will race with setattr */ + /* Lookup again, which will race with the mutator */ ASSERT_EQ(0, stat(FULLPATH, &sb)) << strerror(errno); ASSERT_EQ((off_t)newsize, sb.st_size);