From owner-svn-src-all@FreeBSD.ORG  Sat Mar  9 13:05:22 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 399CC162;
 Sat,  9 Mar 2013 13:05:22 +0000 (UTC)
 (envelope-from davide@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 2C5B6FD3;
 Sat,  9 Mar 2013 13:05:22 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.6/8.14.6) with ESMTP id r29D5LvE060077;
 Sat, 9 Mar 2013 13:05:21 GMT (envelope-from davide@svn.freebsd.org)
Received: (from davide@localhost)
 by svn.freebsd.org (8.14.6/8.14.5/Submit) id r29D5LDA060076;
 Sat, 9 Mar 2013 13:05:21 GMT (envelope-from davide@svn.freebsd.org)
Message-Id: <201303091305.r29D5LDA060076@svn.freebsd.org>
From: Davide Italiano <davide@FreeBSD.org>
Date: Sat, 9 Mar 2013 13:05:21 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r248099 - head/sys/fs/smbfs
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Mar 2013 13:05:22 -0000

Author: davide
Date: Sat Mar  9 13:05:21 2013
New Revision: 248099
URL: http://svnweb.freebsd.org/changeset/base/248099

Log:
  - Initialize variable in smbfs_rename() to silent compiler warning
  - Fix smbfs_mkdir() return value (in case of error).
  
  Reported by:	pho

Modified:
  head/sys/fs/smbfs/smbfs_vnops.c

Modified: head/sys/fs/smbfs/smbfs_vnops.c
==============================================================================
--- head/sys/fs/smbfs/smbfs_vnops.c	Sat Mar  9 12:51:39 2013	(r248098)
+++ head/sys/fs/smbfs/smbfs_vnops.c	Sat Mar  9 13:05:21 2013	(r248099)
@@ -580,6 +580,7 @@ smbfs_rename(ap)
 	u_int16_t flags = 6;
 	int error=0;
 
+	scred = NULL;
 	/* Check for cross-device rename */
 	if ((fvp->v_mount != tdvp->v_mount) ||
 	    (tvp && (fvp->v_mount != tvp->v_mount))) {
@@ -730,7 +731,7 @@ smbfs_mkdir(ap)
 	*ap->a_vpp = vp;
 out:
 	smbfs_free_scred(scred);
-	return 0;
+	return error;
 }
 
 /*