Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Nov 2012 20:04:13 -0800
From:      Xin LI <delphij@gmail.com>
To:        Dimitry Andric <dim@freebsd.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Xin LI <delphij@freebsd.org>
Subject:   Re: svn commit: r242842 - in head/sys: conf modules/mthca
Message-ID:  <CAGMYy3vTh8gm1Xs-UB5NYGNNJGtR6KwQx0k3OGSNsxqu9sctZA@mail.gmail.com>
In-Reply-To: <509EC0E5.6040109@FreeBSD.org>
References:  <201211100032.qAA0Wlvw090497@svn.freebsd.org> <509EC0E5.6040109@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Would you please commit them then?  I am frustrated with the fact that
-HEAD is not buildable for so long time and nobody seems to care doing
tinderbox build pre-commit, which is not acceptable to be honest.

On Saturday, November 10, 2012, Dimitry Andric wrote:

> On 2012-11-10 01:32, Xin LI wrote:
>
>> Author: delphij
>> Date: Sat Nov 10 00:32:47 2012
>> New Revision: 242842
>> URL: http://svnweb.freebsd.org/**changeset/base/242842<http://svnweb.freebsd.org/changeset/base/242842>;
>>
>> Log:
>>    Attempt toward a buildable universe by silenting a few warnings for
>> OFED.
>>
> ...
>
>> -OFEDNOERR=     -Wno-cast-qual -Wno-pointer-arith -fms-extensions
>> +OFEDNOERR=     -Wno-cast-qual -Wno-pointer-arith -fms-extensions
>> -Wno-switch -Wno-sometimes-uninitialized -Wno-conversion
>> -Wno-initializer-overrides
>>
>
> A few of these warnings point to real bugs, e.g. the uninitialized
> packet_length variable in ib_ud_header_init(), and the incorrect value
> passed to rdma_notify() in sdp_rx_comp_work().  The others are not that
> severe, but very easy to fix, as you can see from the attached diff.
>
> If anything, I hope the maintainer(s) will check with upstream whether
> these bugs are already fixed?  Meanwhile, I see no reason why we could
> not do a local fix.
>


-- 
Xin LI <delphij@delphij.net> https://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGMYy3vTh8gm1Xs-UB5NYGNNJGtR6KwQx0k3OGSNsxqu9sctZA>