From owner-svn-src-head@FreeBSD.ORG Sun Nov 11 04:04:15 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D1109C51; Sun, 11 Nov 2012 04:04:15 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 682DC8FC0C; Sun, 11 Nov 2012 04:04:14 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id gg13so270538lbb.13 for ; Sat, 10 Nov 2012 20:04:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1L76toRMUUranp6a+NWLIMW2shAu8btr5XP6RfCXt/w=; b=dPVs+RRHIz/HPj6GPL5nnUqUKTF0ctmkwezecaVTmjR87ZBOrDmSxrXbT121tWyPsK OWXX9VSFMQSzviOj9lTWIQCxD7ChJCjKsDPrw52PYScnOQBHdama9RBP4NKzr9qfMl0F GcAfouemoOjbYODQeKgEVQ7VdvFGx4nHXYjTbAfo9kYzbZLTrdJ+iD56A/FO9tqX9B+z MV2PyZXK6ZyRhwxRrCvAXWaJny1vw+4pOHBPB5a5UK+CHlows7hkogYR9IEOAAaE/Rp+ C9E4rOSF9I2cTFhhkJDdVUU6wQzcyoyDHiK7d7Fv/VSVEw9glcj4y9WQmBOLMopteNIL wIew== MIME-Version: 1.0 Received: by 10.112.43.34 with SMTP id t2mr6257477lbl.109.1352606653199; Sat, 10 Nov 2012 20:04:13 -0800 (PST) Received: by 10.152.111.100 with HTTP; Sat, 10 Nov 2012 20:04:13 -0800 (PST) In-Reply-To: <509EC0E5.6040109@FreeBSD.org> References: <201211100032.qAA0Wlvw090497@svn.freebsd.org> <509EC0E5.6040109@FreeBSD.org> Date: Sat, 10 Nov 2012 20:04:13 -0800 Message-ID: Subject: Re: svn commit: r242842 - in head/sys: conf modules/mthca From: Xin LI To: Dimitry Andric Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Xin LI X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2012 04:04:16 -0000 Would you please commit them then? I am frustrated with the fact that -HEAD is not buildable for so long time and nobody seems to care doing tinderbox build pre-commit, which is not acceptable to be honest. On Saturday, November 10, 2012, Dimitry Andric wrote: > On 2012-11-10 01:32, Xin LI wrote: > >> Author: delphij >> Date: Sat Nov 10 00:32:47 2012 >> New Revision: 242842 >> URL: http://svnweb.freebsd.org/**changeset/base/242842 >> >> Log: >> Attempt toward a buildable universe by silenting a few warnings for >> OFED. >> > ... > >> -OFEDNOERR= -Wno-cast-qual -Wno-pointer-arith -fms-extensions >> +OFEDNOERR= -Wno-cast-qual -Wno-pointer-arith -fms-extensions >> -Wno-switch -Wno-sometimes-uninitialized -Wno-conversion >> -Wno-initializer-overrides >> > > A few of these warnings point to real bugs, e.g. the uninitialized > packet_length variable in ib_ud_header_init(), and the incorrect value > passed to rdma_notify() in sdp_rx_comp_work(). The others are not that > severe, but very easy to fix, as you can see from the attached diff. > > If anything, I hope the maintainer(s) will check with upstream whether > these bugs are already fixed? Meanwhile, I see no reason why we could > not do a local fix. > -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die