From owner-svn-src-all@freebsd.org Sun Apr 9 04:54:12 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6701ED35DAC for ; Sun, 9 Apr 2017 04:54:12 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f66.google.com (mail-lf0-f66.google.com [209.85.215.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E3D4B3E5 for ; Sun, 9 Apr 2017 04:54:11 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f66.google.com with SMTP id x72so1456817lfb.1 for ; Sat, 08 Apr 2017 21:54:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=4sDyreoZ57lEKFLEaTxeAWmDMOzH++bca9a2LKIQ9ck=; b=toEfE8F4Rp5tjjbEqLVE5TQwHgUHV+rpwiqU0KdLS19BC4vIPg0WYZfoCujjjs4HV6 sr34JTRX4BSdDFjzu+G7+QX9lVtRI8QhPZNHvwBjD3Brl/yhn72IW8hogW1JyNnOR219 +oaQ0lNCCLEM8gKa2CZ1heRRPAJoWM5tUZeMbGGJRx+baSUFzwQBpQc3zAt2sR9lvEUk mvzq6axY78ukU1p/duB848tdFviKtxvOSj3/B2KeL71TDPAPqUNxK5w7S1OZM8kqIwDY XIThWAMAd2xlgAuIO446vCV16gkAB6gjXTWfxcTkb45HQmFUmV7kuhH9Hu+zedE/yYcC kzkw== X-Gm-Message-State: AFeK/H2ZIP4UZADoGYheeBkjmWFyKsp+5WigD03uu2sQXQlQiena0EnsVw9bgGrhGnReTA== X-Received: by 10.46.69.133 with SMTP id s127mr13507950lja.44.1491713649481; Sat, 08 Apr 2017 21:54:09 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id i1sm2000887ljd.47.2017.04.08.21.54.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Apr 2017 21:54:08 -0700 (PDT) Subject: Re: svn commit: r316642 - head/sys/dev/syscons To: Bruce Evans , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201704081000.v38A0dBU078784@repo.freebsd.org> From: Andrey Chernov Message-ID: <4a498d83-3b64-18ac-bb0f-890a0c2893fc@freebsd.org> Date: Sun, 9 Apr 2017 07:54:04 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <201704081000.v38A0dBU078784@repo.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Apr 2017 04:54:12 -0000 On 08.04.2017 13:00, Bruce Evans wrote: > Log: > Quick fix for removal of the mouse cursor in vga direct graphics modes > (that is, in all supported 8, 15, 16 and 24-color modes). Moving the > mouse cursor while holding down a button (giving cut marking) left a > trail of garbage from misremoved mouse cursors (usually colored > rectangles and not cursor shapes). Cases with a button not held down > worked better and may even have worked. > > No renderer support for removing (software) mouse cursors is needed > (and many renderers don't have any), since sc_remove_mouse_image() > marks for update the region containing the image and usually much > more. The mouse cursor can be (partially) over as many as 4 character > cells, and removing it in only the 1-4 cells occupied by it would be > best for efficiency and for avoiding flicker. Please don't forget that this 5 cells range (0xd0-0xd4, last one becomes SC_CURSOR_CHAR) can be redefined with "vidcontrol -M", it is needed for the case they overlap valid characters region for some code tables.