From owner-dev-commits-src-main@freebsd.org Tue Sep 21 16:17:45 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0D46A676990; Tue, 21 Sep 2021 16:17:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HDRRD6xB8z3J6W; Tue, 21 Sep 2021 16:17:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CFBA826FB0; Tue, 21 Sep 2021 16:17:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 18LGHi1O036089; Tue, 21 Sep 2021 16:17:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 18LGHiLu036088; Tue, 21 Sep 2021 16:17:44 GMT (envelope-from git) Date: Tue, 21 Sep 2021 16:17:44 GMT Message-Id: <202109211617.18LGHiLu036088@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 559f60214b74 - main - dwmmc: Remove dwmmc_setup_bus call from start_cmd MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 559f60214b7498ac068c5aa1f2bdecc1610bab53 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2021 16:17:45 -0000 The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=559f60214b7498ac068c5aa1f2bdecc1610bab53 commit 559f60214b7498ac068c5aa1f2bdecc1610bab53 Author: Emmanuel Vadot AuthorDate: 2021-09-21 15:52:38 +0000 Commit: Emmanuel Vadot CommitDate: 2021-09-21 16:17:20 +0000 dwmmc: Remove dwmmc_setup_bus call from start_cmd There is no need to re-setup the bus before each commands. Tested-on: Rock64, RockPro64 Reported by: avg --- sys/dev/mmc/host/dwmmc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/mmc/host/dwmmc.c b/sys/dev/mmc/host/dwmmc.c index df7ac374a265..77c8e42a6150 100644 --- a/sys/dev/mmc/host/dwmmc.c +++ b/sys/dev/mmc/host/dwmmc.c @@ -1102,9 +1102,6 @@ dwmmc_start_cmd(struct dwmmc_softc *sc, struct mmc_command *cmd) sc->curcmd = cmd; data = cmd->data; - if ((sc->hwtype & HWTYPE_MASK) == HWTYPE_ROCKCHIP) - dwmmc_setup_bus(sc, sc->host.ios.clock); - #ifndef MMCCAM /* XXX Upper layers don't always set this */ cmd->mrq = sc->req;